Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp694812ybe; Wed, 11 Sep 2019 03:17:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqzChD906J3m3ShS2Y4BA4ecRo8wr9fVgme6GfbAjc6G1I4BpRm2sgcUTBL2ARQSosWp0Bk2 X-Received: by 2002:a17:906:bc2:: with SMTP id y2mr29505051ejg.148.1568197024276; Wed, 11 Sep 2019 03:17:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568197024; cv=none; d=google.com; s=arc-20160816; b=MEAvGOk8NlhQuwL+OouWz+dE/v2cZCsUs33HJw7kloMViCqldYSdKZq7c63Be86hdg QH4V97iai9/Se9m4C0dFxKZkcjjECQbzJ+3Dy5eQ1m451E1u9qFSixC6lnMYjbVxwhQr Fhgs7/vswUtcHsSweiUcS/f38Oy4Zr2nY6N6z31FpScOcGcto8hnFtR6tLbkSlJ8I3aJ JazQXSCSwrj9qdoSwOnmtzoR0z3qRmOqRVfbDhOVLFS/3yrdf8VriMlLmaFnr1dPotPu BEMY0R7Nfpp7MiMnhwpeJhvNh1FsiGAEdo14DHuH4a01yPRu5y7QC0Awb0FmW4U+uhQ9 3b+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=aCnVGzJ1aayFY2KVyD1Mv7oUSY3ckiY/y1eytoodkhs=; b=eG9I5aPFWy8t0gz2jacwddwj3Y665CZcDsJKK8Vpi7qHYgqXH7LVDIblOmakWmv7P0 3dGm+0MdJWALAeHieCu+Yw5xd9YeudRA3IUU5n2U48pA1t08ER8A6DaUcnBCeptY0p2M lnFYnsxjjZfEEOID29smiSAjPv300EOcrBEtoaqxG6ROgzzQnWRUjNKj4EZmTLK9pOQe AqQPhbayhDj+mrwMpNRsjWZYkEHObzrWWBG51yzhHYnQf4rcpU+6GM2ZFQFgjgMC/GrZ BrV9PfgVDBIInuJsiXdGe7WMcKoeVpVhK+Y53x6mqL9L79FzPRmiW9zonyBvv1kzLB/T rQhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IsmloQ3q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si8352144edr.307.2019.09.11.03.16.40; Wed, 11 Sep 2019 03:17:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IsmloQ3q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727645AbfIKKNx (ORCPT + 99 others); Wed, 11 Sep 2019 06:13:53 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:38409 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727577AbfIKKNx (ORCPT ); Wed, 11 Sep 2019 06:13:53 -0400 Received: by mail-lj1-f194.google.com with SMTP id y23so19080801ljn.5 for ; Wed, 11 Sep 2019 03:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aCnVGzJ1aayFY2KVyD1Mv7oUSY3ckiY/y1eytoodkhs=; b=IsmloQ3qh+w0RxxWI9INZ9WRb+/A5095NFWDlOU0ojKcniCg3x8EawwhTpdwT1nI3v LWk8BbA4ERR32ph5dS97WZauymFdmjDcgntluwX6FCCKLbzZdAqN7tjZru61pYKlNRSV QYyHm/3HKhdeo+cTZaEaE87uLdzYHPpP3PD8Kid71nN1CyD+Me+ORjfm5oWjxJQ+zwlL y1TUbT5IxbD0E4ySpZNyKclMiNdDEVSz4nNLYlirjrjnYQNE2KKMLQsl62ayYl2m74Ju ATAllJQxj3IB0o1IYMuC84V5aUBxTRhsNK++jZHUBqWMNK/OxiN931IpoTJv/NAb47f3 hIcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aCnVGzJ1aayFY2KVyD1Mv7oUSY3ckiY/y1eytoodkhs=; b=MXNnvRwjMx0kEv1UQ1bs4rx6Ept26Kx6GLixI4ZoDrWSDGDU2cLFWlvX/TEi1Nu/Ry XFP/gpNMjC0HDwqWU8k9xsGhga7zyNUmgUbm+hlexjan/uBM83pkXr+u7sgeGdyujhSW p5MgbUcPLiV9huH16MMhgteGfISt0ASHlCERtK/GF9JEfGeKPE9JkELuhOCB9ez7Oy7X XnqqA/dBcnNQkh/zuWTPwQOdfySn7h9Y3h8vaQfWfx+wP0a8b63bRXYE7JDS6U0GW5IL bnVFz1toz458/dwu1ojLYuk6E0Dy7t1/6Oq8jaisrNPQT2pQOs4uvL9Gd/+rJ7FLJ6mw mnJA== X-Gm-Message-State: APjAAAX4BF5bjwsHF7X4KxxpWALYAK650v/Bour09WDywmN0IYUTTx2j PRXm8L8q4YJXNUsWyRB7Wmk6B3Q+W8cBWKiF7kKGoQ== X-Received: by 2002:a2e:654a:: with SMTP id z71mr22911168ljb.37.1568196829591; Wed, 11 Sep 2019 03:13:49 -0700 (PDT) MIME-Version: 1.0 References: <20190906063737.15428-1-rashmica.g@gmail.com> In-Reply-To: <20190906063737.15428-1-rashmica.g@gmail.com> From: Linus Walleij Date: Wed, 11 Sep 2019 11:13:38 +0100 Message-ID: Subject: Re: [PATCH v3 5/5] gpio: Add in ast2600 details to Aspeed driver To: Rashmica Gupta Cc: Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 6, 2019 at 7:37 AM Rashmica Gupta wrote: > The ast2600 is a new generation of SoC from ASPEED. Similarly to the > ast2400 and ast2500, it has a GPIO controller for it's 3.3V GPIO pins. > Additionally, it has a GPIO controller for 1.8V GPIO pins. > > As the register names for both controllers are the same and the 36 1.8V > GPIOs and the first 36 of the 3.3V GPIOs are all bidirectional, we can > use the same configuration struct and use the ngpio property to > differentiate between the two sets of GPIOs. > > Signed-off-by: Rashmica Gupta Patch applied. Yours, Linus Walleij