Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190910092731.GA173476@LGEARND20B15> <61418cb7514460e24bfcd431eee9c540e795fcbc.camel@mellanox.com>
In-Reply-To: <61418cb7514460e24bfcd431eee9c540e795fcbc.camel@mellanox.com>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Wed, 11 Sep 2019 20:39:56 +0900
Message-ID: <CADLLry7io3DwrjWU2n9eiFGsA0sseniQYhMRHmR7SjV6pLnk3w@mail.gmail.com>
Subject: Re: [PATCH] net/mlx5: Declare 'rt' as corresponding enum type
To:     Saeed Mahameed <saeedm@mellanox.com>
Cc:     "leon@kernel.org" <leon@kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Bloch <markb@mellanox.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Alex Vesker <valex@mellanox.com>,
        Erez Shitrit <erezsh@mellanox.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

It is good to hear that similar patch was submitted.
Thanks for notification.

Thanks,
Austin Kim

2019=EB=85=84 9=EC=9B=94 11=EC=9D=BC (=EC=88=98) =EC=98=A4=EC=A0=84 2:59, S=
aeed Mahameed <saeedm@mellanox.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On Tue, 2019-09-10 at 18:27 +0900, Austin Kim wrote:
> > When building kernel with clang, we can observe below warning
> > message:
> >
> > drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1080:9:
> > warning: implicit conversion from enumeration type 'enum
> > mlx5_reformat_ctx_type'
> > to different enumeration type 'enum mlx5dr_action_type' [-   Wenum-
> > conversion]
> >       rt =3D MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL;
> >                                 ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1082:9:
> > warning: implicit conversion from enumeration type 'enum
> > mlx5_reformat_ctx_type'
> > to different enumeration type 'enum mlx5dr_action_type' [-   Wenum-
> > conversion]
> >       rt =3D MLX5_REFORMAT_TYPE_L2_TO_L3_TUNNEL;
> >         ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c:1084:51:
> > warning: implicit conversion from enumeration type 'enum
> > mlx5dr_action_type'
> > to different enumeration type 'enum mlx5_reformat_ctx_type'
> > [-  Wenum-conversion]
> >       ret =3D mlx5dr_cmd_create_reformat_ctx(dmn->mdev, rt, data_sz,
> > data,
> >          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~            ^~
> >
> > Declare 'rt' as corresponding enum mlx5_reformat_ctx_type type.
> >
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> Hi Austin, Thanks for the patch:
>
> We already have a similar patch queued for submission.
> https://patchwork.ozlabs.org/patch/1158175/
>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> > index a02f87f..7d81a77 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c
> > @@ -1074,7 +1074,7 @@ dr_action_create_reformat_action(struct
> > mlx5dr_domain *dmn,
> >       case DR_ACTION_TYP_L2_TO_TNL_L2:
> >       case DR_ACTION_TYP_L2_TO_TNL_L3:
> >       {
> > -             enum mlx5dr_action_type rt;
> > +             enum mlx5_reformat_ctx_type rt;
> >
> >               if (action->action_type =3D=3D DR_ACTION_TYP_L2_TO_TNL_L2=
)
> >                       rt =3D MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL;