Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190911055938.GA130589@LGEARND20B15> <20190911151202.0002d12b@nic.cz>
In-Reply-To: <20190911151202.0002d12b@nic.cz>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Wed, 11 Sep 2019 22:48:22 +0900
Message-ID: <CADLLry5Fk6SsF5JTP-MSUF2b9kgyqg4cr9y2N8eqJpFbd8Kx-g@mail.gmail.com>
Subject: Re: [PATCH] bus: moxtet: Update proper type 'size_t' to 'ssize_t'
To:     Marek Behun <marek.behun@nic.cz>
Cc:     linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Good!
Thanks for notification.

2019=EB=85=84 9=EC=9B=94 11=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 10:12, =
Marek Behun <marek.behun@nic.cz>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> Hi Austin,
> this was already fixed and is staged for soc/for-next, see
> https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/commit/?h=3Df=
or-next&id=3D6811d26df50d96635dd339cf8cdf43a6abc0c4b6
>
> Thanks,
> Marek
>
> On Wed, 11 Sep 2019 14:59:38 +0900
> Austin Kim <austindh.kim@gmail.com> wrote:
>
> > The simple_write_to_buffer() returns ssize_t type value,
> > which is either positive or negative.
> >
> > However 'res' is declared as size_t(unsigned int)
> > which contains non-negative type.
> >
> > So 'res < 0' statement is always false,
> > this cannot execute execptional-case  handling.
> >
> > To prevent this case,
> > update proper type 'size_t' to 'ssize_t' for execptional handling.
> >
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> > ---
> >  drivers/bus/moxtet.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> > index 1ee4570..288a9e4 100644
> > --- a/drivers/bus/moxtet.c
> > +++ b/drivers/bus/moxtet.c
> > @@ -514,7 +514,7 @@ static ssize_t output_write(struct file *file, cons=
t char __user *buf,
> >       struct moxtet *moxtet =3D file->private_data;
> >       u8 bin[TURRIS_MOX_MAX_MODULES];
> >       u8 hex[sizeof(bin) * 2 + 1];
> > -     size_t res;
> > +     ssize_t res;
> >       loff_t dummy =3D 0;
> >       int err, i;
> >
>