Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1080693ybe; Wed, 11 Sep 2019 09:05:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFdC3OlMiGxv3KZP9qv41+ygP74BFF8zzp+rJB7LimmCiSPX6m2WyJb+GvA8r5kWeRUrGJ X-Received: by 2002:a05:6402:1485:: with SMTP id e5mr37738507edv.191.1568217912860; Wed, 11 Sep 2019 09:05:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568217912; cv=none; d=google.com; s=arc-20160816; b=vjI6n4kLwwT6vv4703ONETyaVj7qUaAjt/j/o/MUumb+93iJOZiQEbPqgHdCw7OQ4F mjdFb12HM5/7WWGfCyO1Yo0/jZAziRQ/TV7Y3wBZqwdhffWYl9MI2BLSe5UPXAkk0aMX 8YcT6tnBMYDILnOksK7fpxE3l/KNhqt+dsaTiZ6WrBJnW35O8ghGDdA6Iq+RyT0YGGRd Y05HSmP7UTcbN0VodLWRLLSwQfWgDtFjpsV/6y11+AJzbGXUWxpVwNWqm7B9MYLeoEac jD7UBgGy0u4nzUmv9MYLmzku7Mirgk9ObtI4SdYlgR8JxNNWZ2BL0vLtGPXjIh+XlQFZ 71jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=nqFIXyWgahx9E1CwmwaQKpDnx+ZmkBIQb/jrmWBPXws=; b=MiVZb38NhiGKu6whlsLI64xXWXo+OR09lFVl1ppl7b73+yL55xpyVxOoNNw3vzTgyq 837UxDlK3MS6ulJAyvbjKeYE6I7qP0SVUEJwJTAYV3DLo5Zu1QY03UTIAShp+mRhTPCS zaiee9oUEGjcX3ImcGwtyJxM/r7XedFZEAKnWc88Y/Oky/ZsFAidEieZG4Urm+vRI0t0 vPkQsDVOpk8CreoCFgE47vaowXv1zWl6xq6NEkW52MJoWLBy0Vq6UaPHxrOEZs0GNZRa zLi2kjYy/luUdyhVr6lDjNxlbIuAY4gX9EwOO7JmTtrrBT0jtc17vtAtzRfxRKY6sEQ3 RLvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si13063859edc.83.2019.09.11.09.04.48; Wed, 11 Sep 2019 09:05:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728826AbfIKQCw (ORCPT + 99 others); Wed, 11 Sep 2019 12:02:52 -0400 Received: from smtp11.smtpout.orange.fr ([80.12.242.133]:34079 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728819AbfIKQCw (ORCPT ); Wed, 11 Sep 2019 12:02:52 -0400 Received: from localhost.localdomain ([90.126.97.183]) by mwinf5d90 with ME id 0G2h2100b3xPcdm03G2i0h; Wed, 11 Sep 2019 18:02:49 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Wed, 11 Sep 2019 18:02:49 +0200 X-ME-IP: 90.126.97.183 From: Christophe JAILLET To: davem@davemloft.net, vyasevich@gmail.com, nhorman@tuxdriver.com, marcelo.leitner@gmail.com Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] sctp: Fix the link time qualifier of 'sctp_ctrlsock_exit()' Date: Wed, 11 Sep 2019 18:02:39 +0200 Message-Id: <20190911160239.10734-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The '.exit' functions from 'pernet_operations' structure should be marked as __net_exit, not __net_init. Fixes: 8e2d61e0aed2 ("sctp: fix race on protocol/netns initialization") Signed-off-by: Christophe JAILLET --- net/sctp/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c index 2d47adcb4cbe..53746ffeeca3 100644 --- a/net/sctp/protocol.c +++ b/net/sctp/protocol.c @@ -1336,7 +1336,7 @@ static int __net_init sctp_ctrlsock_init(struct net *net) return status; } -static void __net_init sctp_ctrlsock_exit(struct net *net) +static void __net_exit sctp_ctrlsock_exit(struct net *net) { /* Free the control endpoint. */ inet_ctl_sock_destroy(net->sctp.ctl_sock); -- 2.20.1