Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1256659ybe; Wed, 11 Sep 2019 11:54:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHpacLSexqD0CRFLXEgwtGE/0aYU55pbzqPCBLB/RHdGa1hgQFmLZIqwdRzIGrYMXCbGez X-Received: by 2002:a17:906:3443:: with SMTP id d3mr8858355ejb.221.1568228042162; Wed, 11 Sep 2019 11:54:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568228042; cv=none; d=google.com; s=arc-20160816; b=CoyuCpae9BD+yP28uq3azzxhgFnVTB+alDR0BMPiidZ5hzqD/VePLImbzq3xbsrv/+ zzarVqswH2cd7R3nUUPvYLprkL5n4yvn1c9dJc2OCrEFILLgHXSj0stxXc5WQNoX2FFB 9eGfLi4DgI1d21MpV8u2Dzvo9yUU/4yUmRqTd1ZDXoJ/Y1Bg8J0+w7PrN6v4qKKvkC0m Fa1gSdrJTBK1G1n1GaE9eiKt261RHriUx6jenkIxjWQKSUWA7hiq7ufBVkWLGgDUYCte EEfuhJjTZYWMf/9dvZwZlk2GKvuVoXpH9E2zJxFCEfdJq5IS9N9bjpsc3Ry2dl0bQnz6 RJZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=nuHW+aHYxVzQ1DRk/87kaXyFXxm/UzZVjR8CBj+6X1M=; b=IOqHP6/tCYreRBgo/twm+BtrH2ze6M4hOKC/br2PxDeAKQgiy3FBcRULyJy0mlogS7 kRiKzptO7jEIEkK4Dr45M8bPYRO+hM1NP0qyFNpTn2KgAtUiDb2Gg82KwmInrliwUk9Q wbiujZsAv90s5a8FeCfapvnhylXEoTj/he0XxCTjunelMcAtMGwOHyWUpyfItmYWpyz9 VNjurn78LgkkVpomji7hDO4bpLwTdEUZMLkvBAjKyfBAyLYSlEXjq6RtviyV7cn6BeUv KcSnGJJXgHMqEoQ9WmmprpMNVEASbjvQahe8fAWyjFIcrQWZDabC6AsD6dopDmD8On+P 0rAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k9si13743780edb.56.2019.09.11.11.53.38; Wed, 11 Sep 2019 11:54:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730253AbfIKSuo (ORCPT + 99 others); Wed, 11 Sep 2019 14:50:44 -0400 Received: from mga06.intel.com ([134.134.136.31]:39421 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729016AbfIKSum (ORCPT ); Wed, 11 Sep 2019 14:50:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 11:50:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="196980862" Received: from sjchrist-coffee.jf.intel.com ([10.54.74.41]) by orsmga002.jf.intel.com with ESMTP; 11 Sep 2019 11:50:40 -0700 From: Sean Christopherson To: James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Marc Zyngier Cc: David Hildenbrand , Cornelia Huck , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , James Morse , Julien Thierry , Suzuki K Pouloze , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: [PATCH 00/13] KVM: Dynamically size memslot arrays Date: Wed, 11 Sep 2019 11:50:25 -0700 Message-Id: <20190911185038.24341-1-sean.j.christopherson@intel.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The end goal of this series is to dynamically size the memslot array so that KVM allocates memory based on the number of memslots in use, as opposed to unconditionally allocating memory for the maximum number of memslots. On x86, each memslot consumes 88 bytes, and so with 2 address spaces of 512 memslots, each VM consumes ~90k bytes for the memslots. E.g. given a VM that uses a total of 30 memslots, dynamic sizing reduces the memory footprint from 90k to ~2.6k bytes. The changes required to support dynamic sizing are relatively small, e.g. are essentially contained in patches 12/13 and 13/13. Patches 1-11 clean up the memslot code, which has gotten quite crusy, especially __kvm_set_memory_region(). The clean up is likely not strictly necessary to switch to dynamic sizing, but I didn't have a remotely reasonable level of confidence in the correctness of the dynamic sizing without first doing the clean up. Testing, especially non-x86 platforms, would be greatly appreciated. I'd really like to get at least one Tested-by from all architectures. The non-x86 changes are for all intents and purposes untested, e.g. I compile tested pieces of the code by copying them into x86, but that's it. In theory, the vast majority of the functional changes are arch agnostic, in theory... Sean Christopherson (13): KVM: Reinstall old memslots if arch preparation fails KVM: PPC: Move memslot memory allocation into prepare_memory_region() KVM: x86: Allocate memslot resources during prepare_memory_region() KVM: Drop kvm_arch_create_memslot() KVM: Refactor error handling for setting memory region KVM: Move setting of memslot into helper routine KVM: Move memslot deletion to helper function KVM: Simplify kvm_free_memslot() and all its descendents KVM: Clean up local variable usage in __kvm_set_memory_region() KVM: Provide common implementation for generic dirty log functions KVM: Ensure validity of memslot with respect to kvm_get_dirty_log() KVM: Terminate memslot walks via used_slots KVM: Dynamically size memslot array based on number of used slots arch/mips/include/asm/kvm_host.h | 2 +- arch/mips/kvm/mips.c | 68 +--- arch/powerpc/include/asm/kvm_ppc.h | 14 +- arch/powerpc/kvm/book3s.c | 22 +- arch/powerpc/kvm/book3s_hv.c | 36 +- arch/powerpc/kvm/book3s_pr.c | 20 +- arch/powerpc/kvm/booke.c | 17 +- arch/powerpc/kvm/powerpc.c | 13 +- arch/s390/include/asm/kvm_host.h | 2 +- arch/s390/kvm/kvm-s390.c | 21 +- arch/x86/include/asm/kvm_page_track.h | 3 +- arch/x86/kvm/page_track.c | 15 +- arch/x86/kvm/x86.c | 100 ++--- include/linux/kvm_host.h | 48 +-- virt/kvm/arm/arm.c | 47 +-- virt/kvm/arm/mmu.c | 18 +- virt/kvm/kvm_main.c | 546 ++++++++++++++++---------- 17 files changed, 467 insertions(+), 525 deletions(-) -- 2.22.0