Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 0/3] fix emulation error on Windows bootup
To:     Jan Dakinevich <jan.dakinevich@virtuozzo.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     Denis Lunev <den@virtuozzo.com>,
        Roman Kagan <rkagan@virtuozzo.com>,
        Denis Plotnikov <dplotnikov@virtuozzo.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
References: <1566911210-30059-1-git-send-email-jan.dakinevich@virtuozzo.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Openpgp: preference=signencrypt
Message-ID: <b35c8b24-7531-5a5d-1518-eaf9567359ae@redhat.com>
Date:   Wed, 11 Sep 2019 17:51:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <1566911210-30059-1-git-send-email-jan.dakinevich@virtuozzo.com>
Content-Type: text/plain; charset=iso-8859-2
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 27/08/19 15:07, Jan Dakinevich wrote:
> This series intended to fix (again) a bug that was a subject of the 
> following change:
> 
>   6ea6e84 ("KVM: x86: inject exceptions produced by x86_decode_insn")
> 
> Suddenly, that fix had a couple mistakes. First, ctxt->have_exception was 
> not set if fault happened during instruction decoding. Second, returning 
> value of inject_emulated_instruction was used to make the decision to 
> reenter guest, but this could happen iff on nested page fault, that is not 
> the scope where this bug could occur.
> 
> However, I have still deep doubts about 3rd commit in the series. Could
> you please, make me an advise if it is the correct handling of guest page 
> fault?
> 
> Jan Dakinevich (3):
>   KVM: x86: fix wrong return code
>   KVM: x86: set ctxt->have_exception in x86_decode_insn()
>   KVM: x86: always stop emulation on page fault
> 
>  arch/x86/kvm/emulate.c | 4 +++-
>  arch/x86/kvm/x86.c     | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 

Queued, thanks.  I added the WARN_ON_ONCE that Sean suggested.

Paolo