Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4/8] x86/platform/uv: Setup UV functions for Hubless UV
 Systems
From:   Mike Travis <mike.travis@hpe.com>
To:     Ingo Molnar <mingo@kernel.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>,
        Christoph Hellwig <hch@infradead.org>,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Russ Anderson <russ.anderson@hpe.com>,
        Hedi Berriche <hedi.berriche@hpe.com>,
        Steve Wahl <steve.wahl@hpe.com>,
        Justin Ernst <justin.ernst@hpe.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
References: <20190910145839.604369497@stormcage.eag.rdlabs.hpecorp.net>
 <20190910145839.975787119@stormcage.eag.rdlabs.hpecorp.net>
 <20190911060702.GD104115@gmail.com>
 <e3a3d64d-87ff-d6de-c550-9a3249b687dd@hpe.com>
Message-ID: <e10cd5c2-c0b0-60f6-ee49-12ff62a483ef@hpe.com>
Date:   Wed, 11 Sep 2019 13:58:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <e3a3d64d-87ff-d6de-c550-9a3249b687dd@hpe.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 9/11/2019 1:44 PM, Mike Travis wrote:
> 
> 
> On 9/10/2019 11:07 PM, Ingo Molnar wrote:
>>
>> * Mike Travis <mike.travis@hpe.com> wrote:
>>
>>> +/* Initialize UV hubless systems */
>>> +static __init int uv_system_init_hubless(void)
>>> +{
>>> +??? int rc;
>>> +
>>> +??? /* Setup PCH NMI handler */
>>> +??? uv_nmi_setup_hubless();
>>> +
>>> +??? /* Init kernel/BIOS interface */
>>> +??? rc = uv_bios_init();
>>> +
>>> +??? return rc;
>>> +}
> 
> This looks like an excessive cleanup error by me.? The original was:
> 
>> +static __init int uv_system_init_hubless(void)
>> +{
>> +?????? int rc;
>> +
>> +?????? /* Setup PCH NMI handler */
>> +?????? uv_nmi_setup_hubless();
>> +
>> +?????? /* Init kernel/BIOS interface */
>> +?????? rc = uv_bios_init();
>> +
>> +?????? /* Create user access node if UVsystab available */
>> +?????? if (rc >= 0)
>> +?????????????? uv_setup_proc_files(1);
>> +
>> +?????? return rc;
>> +}
>> +
> 
> Hubbed UV's do not have a non-UV BIOS, but hubless systems in theory 
> can.?? So uv_bios_init can fail on hubless systems if it has some other 
> BIOS (unlikely but possible).? So I removed too much in this cleanup. 
> I'll send another patch set that puts this back.

I discovered the problem... In a rearrangement of the patches this 
change does happen but in a later patch [5/8]:

  /* Initialize UV hubless systems */
  static __init int uv_system_init_hubless(void)
  {
@@ -1468,6 +1555,10 @@ static __init int uv_system_init_hubless
         /* Init kernel/BIOS interface */
         rc = uv_bios_init();

+       /* Create user access node if UVsystab available */
+       if (rc >= 0)
+               uv_setup_proc_files(1);
+
         return rc;
  }

The mistake you saw [in patch 3/8] is very short lived... Hopefully no 
need for another patch set?

> 
> Thanks,
> Mike
> 
>>
>> Am I the only one who immediately sees the trivial C transformation
>> through which this function could lose a local variable and become 4
>> lines shorter?
>>
>> And this function got two Reviewed-by tags...
>>
>> Thanks,
>>
>> ????Ingo
>>