Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] Added QUIRKs for ADATA XPG SX8200 Pro 512GB
To:     Gabriel C <nix.or.die@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>
References: <CAEJqkgjJEHmTT3N42BXkeb+2mDbteE1YwW25cgUpMk7A_sOWzg@mail.gmail.com>
 <6a47a06d-f8f1-1865-1919-5ede359d0b10@kernel.dk>
 <CAEJqkgguW183DsU+JUPcV193HtDXzVsyUa4JEgVKrhumYTzpAg@mail.gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <856d3393-53c7-5c32-7c87-a682f6abc090@kernel.dk>
Date:   Wed, 11 Sep 2019 16:23:09 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <CAEJqkgguW183DsU+JUPcV193HtDXzVsyUa4JEgVKrhumYTzpAg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/11/19 4:18 PM, Gabriel C wrote:
> Am Mi., 11. Sept. 2019 um 23:33 Uhr schrieb Jens Axboe <axboe@kernel.dk>:
>>
>> On 9/11/19 3:21 PM, Gabriel C wrote:
>>>    Booting with default_ps_max_latency_us >6000 makes the device fail.
>>>    Also SUBNQN is NULL and gives a warning on each boot/resume.
>>>     $ nvme id-ctrl /dev/nvme0 | grep ^subnqn
>>>       subnqn    : (null)
>>>
>>>    I use this device with an Acer Nitro 5 (AN515-43-R8BF) Laptop.
>>>    To be sure is not a Laptop issue only, I tested the device on
>>>    my server board too with the same results.
>>>    ( with 2x,4x link on the board and 4x on a PCI-E card ).
>>>
>>>    Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
>>>    Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
>>
>> For some reason your commit message is indented. Additionally, your
>> patch is whitespace damaged. So this won't apply anywhere.
> 
> Gmail hates me it seems. Sry but I don't have an proper setup on that
> box right now.
> My Laptop died and I try to fix the usual issue for new Laptops on
> this one right now.
> I uploaded the git patch, if you accept it like this. If not I will
> re-send as soon I fix
> this laptop and have git* and other things proper set up.

Use git send-email, it's trivial to use with gmail. That's what I use
and that works fine. If you use gmail (web) for kernel development,
you're going to have a really bad time.

-- 
Jens Axboe