Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1672521ybe; Wed, 11 Sep 2019 19:57:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6j46i62DOMC8WJlw1CoulLzhu+93QmrYDdOFZO2mk+UkDL6odxvz6l5G1Ug4H7h10ZLGn X-Received: by 2002:a17:906:5c52:: with SMTP id c18mr32860813ejr.156.1568257040504; Wed, 11 Sep 2019 19:57:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568257040; cv=none; d=google.com; s=arc-20160816; b=SAk9mUNFEnQwRCcwxl9vuiXa1J4RIXGauC9P2ZUqs4fx+xR+HoH/DsmK8Lts4+a/pW Xn4qnvcGNVLasmG/bz83NoD1TA99HkE4iOX7P96us7XQ+HDZArVOgyVknk+FqjC3Oqo9 rFj6gDyVW5hAYIDVq5mcC4+3WpSvD4mErDPkG7qZCBawQTKNAJQAwoXM/k0TKunvX4IS g2duE5siIW5gzNgVJ11alNpDDkrODZUwWS7M4e36LU2lqj/cXzMOTpelnckgliHlaPAi /Z1PU3ionBHJK2e8f3mGRmkIS8H8HDbz29a+ZXyH+EbiqYczac/9Visb2Eij1wcRRYK9 24Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=717l4cD4Wzf0xH5nDJTl15ClpUuQOFo2fyYpt1Q/w+k=; b=ul/P9+SEMnsEg0qT06NKeXchbe/Ks6kPVlQJ4/WXEWFtgX/hVQASOzgP8AdZpLg76r RSZ9P+5TMYoOpX24UVlOXdN2MPRanmwUW43y/1NOQaftzAZSAJMJx2U1jiT9XoIMh/PW zqX+5mOf1F5xrnKIAnSVSYfGiSSo71LXze6ywTXsL595KTabXLCIp0UufemvUBPui6EZ VH/Fu0fY6jFH4IY0n7jWBkhGK1tVLlwWQQbzf7JviWCrhg0xqkb8kX4icqQ4R7Mtldkg K6M7abixL44D+Jq9aa+Pln+Ko//elockEwSQmMNDjscrxTUpGxAuum5ZR529PZxQx/4h Cn0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mLbAumr3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y16si9907272eje.248.2019.09.11.19.56.56; Wed, 11 Sep 2019 19:57:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=mLbAumr3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728265AbfILC2M (ORCPT + 99 others); Wed, 11 Sep 2019 22:28:12 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:44822 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727477AbfILC2M (ORCPT ); Wed, 11 Sep 2019 22:28:12 -0400 Received: by mail-pf1-f194.google.com with SMTP id q21so14911841pfn.11 for ; Wed, 11 Sep 2019 19:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=717l4cD4Wzf0xH5nDJTl15ClpUuQOFo2fyYpt1Q/w+k=; b=mLbAumr3DrZozScwMs30++F+mc9LHyzJ1lI4nMTznNNyIfv8T3I92qVVOQ8PuMD+O1 yKJGaeibE3xja5CAapYuI2Pa851bdGq+UEXTP+xyeeW9V7gieFN0dsE5RWKeTUi9Azgt RiBIxCQWng9eeHY5ruYHNqm+jPmq4OvTg8+ug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=717l4cD4Wzf0xH5nDJTl15ClpUuQOFo2fyYpt1Q/w+k=; b=OvK+WynKIjrWW32Qm8nhzrCf+DtNzpaaWPuXVvbC1QmqQ5be8N4QM/ai8I/JMPLWiU 212mPY8jrLSHw0OnnnzZgxZV0pIxr/nxpdSGgG9XuMGWow5weLvRZA+4J6GtPtKX/3zX dKszuCetq9AJaBv1zzksopvYjoGQXEn6BNdpbcY2cPqHWBj44CcqzrD6ib6zfAnSf1tv l1PhOyFKVoMCl9z5GsKJ6RBNFeYxfdeUFUMrHgV0T0zoqVGCsEps9HyhTXMiwybIxsvb EVzNzESbgflJGzu9hDwOaufkCGNxja1VueZCZRlIAHo6Pp35AnMPEblSpfCxWdaW97LY teyw== X-Gm-Message-State: APjAAAV3yGC5U0x4gyeo4FmKYKfsLhuidNMNVnPpoIJUjgeBRNcV+zDz NOot2tLEnHovsl9x6MNlc0mcUbXV5Mw= X-Received: by 2002:a63:ad49:: with SMTP id y9mr343398pgo.30.1568255291271; Wed, 11 Sep 2019 19:28:11 -0700 (PDT) Received: from localhost ([2401:fa00:1:10:845f:e35d:e30c:4b47]) by smtp.gmail.com with ESMTPSA id e21sm7539616pgr.43.2019.09.11.19.28.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2019 19:28:10 -0700 (PDT) From: Yu-Hsuan Hsu To: linux-kernel@vger.kernel.org Cc: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Mark Brown , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Tzung-Bi Shih , Yu-Hsuan Hsu , Thomas Gleixner , alsa-devel@alsa-project.org Subject: [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Add dmic format constraint Date: Thu, 12 Sep 2019 10:27:40 +0800 Message-Id: <20190912022740.161798-1-yuhsuan@chromium.org> X-Mailer: git-send-email 2.23.0.162.g0b9fbb3734-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 24 bits recording from DMIC is not supported for KBL platform because the TDM slot between PCH and codec is 16 bits only. We should add a constraint to remove that unsupported format. Signed-off-by: Yu-Hsuan Hsu --- sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c index 74dda8784f1a01..67b276a65a8d2d 100644 --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c @@ -400,6 +400,9 @@ static int kabylake_dmic_startup(struct snd_pcm_substream *substream) snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS, dmic_constraints); + runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; + snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16); + return snd_pcm_hw_constraint_list(substream->runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &constraints_rates); } -- 2.23.0.162.g0b9fbb3734-goog