Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1882901ybe; Thu, 12 Sep 2019 00:42:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqy+S0ESbX/JA2qaHrWN5wKyKT1L7FkBIKgj2t4s0sIePJVF2EyXTK8LQwuj1yCtgNv4uskm X-Received: by 2002:a50:ed0f:: with SMTP id j15mr32752602eds.127.1568274147194; Thu, 12 Sep 2019 00:42:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568274147; cv=none; d=google.com; s=arc-20160816; b=s3N+HCr04K3aH5wmkr6/Ihtb0jyptzavObTru84e9jrCHJe7xEaOmmu6ckB1CSRJkZ /DSmD/pgpctw9YI6Gd3cTbK3XyEBJqI9fQFlc7Ux5MF+IPEAMXevA2qDLK9IEGYTIXRI uagqP667BJxJlM4pi7hqLgbxzrPQL/2CkZCx9DdUoPsb+Oq1Iu0cGbXrbAlRbDwRMLT6 aZkApJupkY4ddAUGo3JOGSnZqPw0qEvAP+kLJg4GT3Dppsme1l7hIwNh9EuOTmWZBLCi zxABlQ9LZO8cT427AFp2RJBbWEBXbtcyxPzIDiTJosNfCkFk3+g2+d/m/tsrAeGDdCQu CPCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=G1BcjHOJZc7rpLgwUY5wqK3l0LgE3Dl/cZ9Zeu9lt0o=; b=lV21Xarq3GgQb9bqXQYX3J+J9So7Etre6FGi2AfNWBTlqD86kBjMbbCvaa4uQEwn7t Bh0kr1BoiN+KacMa7KVsOkmfQ2xULqQJZqBBVqXTl01DcC1Lb+7k3c9Yh3KjzYfSxzz7 Qk50UbrNJEgjsst+Dpkea+KmadObXk62vPorZphTnrdZ6B+joVPKxNWRJAqhQanotJk0 aOjsvBG9tc5jOiT/P8O6ZcmYnafWWTDX9xVjz6jEv/zNsD7x2gpI35oGZv+Q/4rVSncK l11+oV4PfpVNdyzAyBqlOHu7W3FmPZjrMcxbn5H30rCtqhAo/PAdyF/OvJMqnOpZUbwo 7itw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3si11401628edq.336.2019.09.12.00.42.01; Thu, 12 Sep 2019 00:42:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729656AbfILHBX (ORCPT + 99 others); Thu, 12 Sep 2019 03:01:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:40181 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbfILHBX (ORCPT ); Thu, 12 Sep 2019 03:01:23 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2019 00:01:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="385948639" Received: from linux.intel.com ([10.54.29.200]) by fmsmga006.fm.intel.com with ESMTP; 12 Sep 2019 00:01:21 -0700 Received: from [10.226.39.17] (ekotax-mobl.gar.corp.intel.com [10.226.39.17]) by linux.intel.com (Postfix) with ESMTP id C69F9580887; Thu, 12 Sep 2019 00:01:17 -0700 (PDT) Subject: Re: [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver To: Andy Shevchenko , Andrew Murray Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, lorenzo.pieralisi@arm.com, robh@kernel.org, martin.blumenstingl@googlemail.com, linux-pci@vger.kernel.org, hch@infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com References: <35316bac59d3bc681e76d33e0345f4ef950c4414.1567585181.git.eswara.kota@linux.intel.com> <20190905104517.GX9720@e119886-lin.cambridge.arm.com> <20190905114016.GF2680@smile.fi.intel.com> From: Dilip Kota Message-ID: Date: Thu, 12 Sep 2019 15:01:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190905114016.GF2680@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 9/5/2019 7:40 PM, Andy Shevchenko wrote: > On Thu, Sep 05, 2019 at 11:45:18AM +0100, Andrew Murray wrote: >> On Wed, Sep 04, 2019 at 06:10:31PM +0800, Dilip Kota wrote: >>> Add support to PCIe RC controller on Intel Universal >>> Gateway SoC. PCIe controller is based of Synopsys >>> Designware pci core. >>> +config PCIE_INTEL_AXI > I think that name here is too generic. Classical x86 seems not using this. This PCIe driver is for the Intel Gateway SoCs. So how about naming it is as "pcie-intel-gw"; pcie-intel-gw.c and Kconfig as PCIE_INTEL_GW. Andrew Murray is ok with this naming, please let me know your view. > >>> + bool "Intel AHB/AXI PCIe host controller support" >>> + depends on PCI_MSI >>> + depends on PCI >>> + depends on OF >>> + select PCIE_DW_HOST >>> + help >>> + Say 'Y' here to enable support for Intel AHB/AXI PCIe Host >>> + controller driver. >>> + The Intel PCIe controller is based on the Synopsys Designware >>> + pcie core and therefore uses the Designware core functions to >>> + implement the driver.