Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2071998ybe; Thu, 12 Sep 2019 04:11:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3q4W5kcJmvKplYMaRTcnvpbt8QMvvFIEZVsi0KKg7qCJACujjk2NTE3cWn7lKfvu3P4Um X-Received: by 2002:aa7:c719:: with SMTP id i25mr14212288edq.5.1568286689398; Thu, 12 Sep 2019 04:11:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568286689; cv=none; d=google.com; s=arc-20160816; b=rrH2OY7Apzx+KugOFxe1kuOrx4hQRr7DqKuH4zg2iLLTH/M3jksoVeXxdTefKXiHd3 zMM16CtKkKTjmuwf8oWSctJXOM0Z+ByTP8rsajxSCw2t4enQJKzhRtyLTqJBJiVA6J6z WaVfPcNafZETYQp0eOWDOiYrFD8J/+FYvFW+PQGjUZFGdQVMSxTm9oV8HXS6dRhUcSMt B1p/5DD5vyNNr8zfKBOXSzb2Emds90C4Rf0w/lQKX5Bjs3hpF9mP35hyTM1SX1iIjwWX xiUsLdRNSsAL9arWx+PHD2Aw3c0qLmXj4a4FlCckpl5AvLX5BZAkZApfjvU6WM2hcGnY ex5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:references :in-reply-to:message-id:date:subject:cc:to:from; bh=dhNrhOrEbT4k1DOJtQtyO3zay/QTs33tZUSTiEZrO8U=; b=UVZRia8d5NK4qix+olvhMLlTaUNXCqLAhf5Ur+qKmm7cII3hDEEtpL6q7gSsBhywUT 0nc1HYIZzS6lDr2Y/I8tczlj4kSEM8g5P6cGIIEwh1kkmkUtuWljB+In89QIb2vrq1b1 fhwOQE/h2bSWERyQnc3kFXWw1Ah0h+QrD/nTTQkJVpT7wLU5jgZU2BuecsO2dYz2PUoE XjsraggVKspNBVN+lALINxzncTXsM0ob01AUGqXwDOc1ZUnfZog82hhsQAOiTFlPVKvd E70xFPfg7xLpx9ElTrzXRZ7O+u+1rNGsv3PIT689qg/tSEO99chs4OhrGcbjRzc9GIfK MrGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u13si11519673edx.360.2019.09.12.04.11.05; Thu, 12 Sep 2019 04:11:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731346AbfILLGb (ORCPT + 99 others); Thu, 12 Sep 2019 07:06:31 -0400 Received: from mail.thorsis.com ([92.198.35.195]:43925 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731203AbfILLGa (ORCPT ); Thu, 12 Sep 2019 07:06:30 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 7BD944858; Thu, 12 Sep 2019 13:08:05 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aqkhD7EjSDJZ; Thu, 12 Sep 2019 13:08:05 +0200 (CEST) Received: by mail.thorsis.com (Postfix, from userid 109) id 655798D6B; Thu, 12 Sep 2019 13:08:02 +0200 (CEST) X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RECEIVED, NO_RELAYS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 From: Alexander Dahl To: linux-arm-kernel@lists.infradead.org Cc: Eugen.Hristev@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, alexandre.belloni@bootlin.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: at91: allow 24 Mhz clock as input for PLL Date: Thu, 12 Sep 2019 13:06:20 +0200 Message-ID: <30755021.BkS3ObC0RA@ada> In-Reply-To: <1568183622-7858-1-git-send-email-eugen.hristev@microchip.com> References: <1568183622-7858-1-git-send-email-eugen.hristev@microchip.com> Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, out of curiosity: The SAMA5D27-SOM1-EK board has a 24 MHz crystal, that is also what /sys/kernel/debug/clk/clk_summary says and the board runs without obvious problems. What is this change improving in real practice then? Greets Alex Am Mittwoch, 11. September 2019, 06:39:20 CEST schrieb Eugen.Hristev@microchip.com: > From: Eugen Hristev > > The PLL input range needs to be able to allow 24 Mhz crystal as input > Update the range accordingly in plla characteristics struct > > Signed-off-by: Eugen Hristev > --- > drivers/clk/at91/sama5d2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/at91/sama5d2.c b/drivers/clk/at91/sama5d2.c > index 6509d09..0de1108 100644 > --- a/drivers/clk/at91/sama5d2.c > +++ b/drivers/clk/at91/sama5d2.c > @@ -21,7 +21,7 @@ static const struct clk_range plla_outputs[] = { > }; > > static const struct clk_pll_characteristics plla_characteristics = { > - .input = { .min = 12000000, .max = 12000000 }, > + .input = { .min = 12000000, .max = 24000000 }, > .num_output = ARRAY_SIZE(plla_outputs), > .output = plla_outputs, > .icpll = plla_icpll,