Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2127729ybe; Thu, 12 Sep 2019 05:05:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1v6I9GCrvCfVHgxS9EHUmca8HC9TzJQ4h0Gz3M8I+aaKWfeco2i5XafuUMZ7bSGPtlZd/ X-Received: by 2002:a50:ed1a:: with SMTP id j26mr30032444eds.138.1568289934721; Thu, 12 Sep 2019 05:05:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568289934; cv=none; d=google.com; s=arc-20160816; b=dGvtAhzZTD9FZuUY9BqFPplJL+pbbKKrCSj8phvSO804Y0HWvjlA5DBbL0V471DAEn nuUa76y3dxcjyDCYdE5v4pbTEvLgCoihAHJLO3SgGniTVB6HHnkV+EW6dyF8CAz1+uPi Ir9SZO7psQ6sKj4U8fYmfWbKNrQwvfzmWII+l4p7hZEDlJ0R//1g6jfN3AdtdP1TciwF opgwkKL39jH/oD+yoDreBwYdoIJz1smg0jvBiyXmw3M39k8saWzlwaW2BoQDGaIqwoyg 8MT3gbsxw5s6d13OOw0aFtkYwYGjndtiPhSqqHS0Grmo2x8UwhYMAaiWExv4QHANitpe AidA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=FYtDp2gQu85OzThc5ikz2A0+zoE1rUIOtPZpolymb7k=; b=nW2ZPrUr+1el9l7BBmwYWXbR3Ak7IzyrkThZVRt06M27Y8sTTHtpkJtzGcdvkMq9o+ aXINOOn7HKogCbIjdyMX4e/T31ztNsesELcuiqGGFTIvPk1gl8e1VIV2+7Fu1DZKFacr JFJwn1UARuxiFlbZBwjir/bgIr6xfS1JLxVgch6anXVnoJUQCTKTIR1ofdKKvHx/AM1c tmx4aCQcc4oe2L6RlQzYbibR1XiiKNrkM5SiY3WmJoSTR+AhEwf71Dj6Sj3p/FQolzxh Lj3ozaCeUiZTH/OuEnpol7bT7kN/lqXOtNgLo9nRqsvaKar2zlSxMdl6IrkKjaYpEo11 SUKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=LLpYNGLW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x15si15511645eda.53.2019.09.12.05.05.10; Thu, 12 Sep 2019 05:05:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=LLpYNGLW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731540AbfILL7q (ORCPT + 99 others); Thu, 12 Sep 2019 07:59:46 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:44656 "EHLO mail-lf1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731483AbfILL7p (ORCPT ); Thu, 12 Sep 2019 07:59:45 -0400 Received: by mail-lf1-f47.google.com with SMTP id q11so4174139lfc.11 for ; Thu, 12 Sep 2019 04:59:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FYtDp2gQu85OzThc5ikz2A0+zoE1rUIOtPZpolymb7k=; b=LLpYNGLWO+FOw9m0V2uY2cWrgwX2O+ZH+hY2GxqW7nLiXxw6ee3Ik7+QES/hMd+qb8 2x3Frma/RnZ2/wtXERUJiZagrYagqPoKxFlYUzMKqK3e8vRhNqLRhufV+rTV7H4gg9gy D9Cua/F/D39AXmf2DrMb8Hit7DqqxEheHEYOM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FYtDp2gQu85OzThc5ikz2A0+zoE1rUIOtPZpolymb7k=; b=C7HO/bWOTVGjwOHZi+fT49x2a55+PasGe/+fC5WZDR9LPYB+mugy2l3kcuTakk05mA dGbcgo7cnpgYfLzVBC5jilLtr0pktZZtIHvxeGISA8Kx8F0wwVmN8VZbrmDAwCzdnhre zmlkhF0yixFDA0CQt+850eXBYPBPIUT+NfnOjbmTm0bot3IPHUarGReLEKxRgzKP3oGs Ohq+MsOWaXSud1E8+V1ptj/+sHHUKNoWV3UU0tdXQ0g0dyKbADdZUEG8wkVaK/JSzx0B ElQOH0/Wgt4XVXF0Yicko1bJh2irtFyvhT6euU8ME657UCT6RFsHTUplJQbBoRjv4voG hYGw== X-Gm-Message-State: APjAAAXPVJ7Tfjum3fucOqgbBKSLGYYnR74f/Y2Ddi7bz33AxtPSQLZz mLoy7c5tjcR+L8HhYvjPjZsyV09FdKyLaA== X-Received: by 2002:ac2:4ad9:: with SMTP id m25mr668198lfp.89.1568289582995; Thu, 12 Sep 2019 04:59:42 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id j7sm6323984lfc.16.2019.09.12.04.59.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2019 04:59:42 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id q11so4174035lfc.11 for ; Thu, 12 Sep 2019 04:59:41 -0700 (PDT) X-Received: by 2002:a19:741a:: with SMTP id v26mr27747225lfe.79.1568289581382; Thu, 12 Sep 2019 04:59:41 -0700 (PDT) MIME-Version: 1.0 References: <156535522344.29541.9312856809559678262@skylake-alporthouse-com> <20190910142047.GB3029@papaya> <3dcff41048621ff440687dd6691aae31a8647a1e.camel@suse.com> In-Reply-To: <3dcff41048621ff440687dd6691aae31a8647a1e.camel@suse.com> From: Linus Torvalds Date: Thu, 12 Sep 2019 12:59:25 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: 5.3-rc3: Frozen graphics with kcompactd migrating i915 pages To: Martin Wilck Cc: "chris@chris-wilson.co.uk" , Michal Koutny , "intel-gfx@lists.freedesktop.org" , "leho@kraav.com" , "tiwai@suse.de" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 12, 2019 at 12:51 PM Martin Wilck wrote: > > Is there an alternative to reverting aa56a292ce62 ("drm/i915/userptr: > Acquire the page lock around set_page_dirty()")? And if we do, what > would be the consequences? Would other patches need to be reverted, > too? Looking at that commit, and the backtrace of the lockup, I think that reverting it is the correct thing to do. You can't take the page lock in invalidate_range(), since it's called from try_to_unmap(), which is called with the page lock already held. So commit aa56a292ce62 is just fundamentally completely wrong and should be reverted. Linus