Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Arnd Bergmann <arnd@arndb.de>
CC:     Christian Benvenuti <benve@cisco.com>,
        Nelson Escobar <neescoba@cisco.com>,
        Parvi Kaustubhi <pkaustub@cisco.com>,
        Doug Ledford <dledford@redhat.com>,
        Leon Romanovsky <leon@kernel.org>,
        Gal Pressman <galpress@amazon.com>,
        Parav Pandit <parav@mellanox.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Kamal Heib <kamalheib1@gmail.com>,
        Florian Westphal <fw@strlen.de>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usnic: avoid overly large buffers on stack
Thread-Topic: [PATCH] usnic: avoid overly large buffers on stack
Thread-Index: AQHVaXCjw/Ut2E8kMkCNr8L8Y0rqrA==
Date:   Thu, 12 Sep 2019 13:47:37 +0000
Message-ID: <20190912134722.GA26019@mellanox.com>
References: <20190906155730.2750200-1-arnd@arndb.de>
In-Reply-To: <20190906155730.2750200-1-arnd@arndb.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [199.167.24.153]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b4d6389d-f3f4-4d99-10d3-08d73787c5ff
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR05MB4687;
x-ms-traffictypediagnostic: VI1PR05MB4687:|VI1PR05MB4687:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <VI1PR05MB468735F7649FA05A5BC7D3CDCFB00@VI1PR05MB4687.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-forefront-prvs: 01583E185C
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(199004)(189003)(8676002)(81166006)(86362001)(81156014)(14454004)(6916009)(256004)(305945005)(6486002)(7736002)(33656002)(2616005)(3846002)(54906003)(476003)(6116002)(25786009)(6506007)(26005)(386003)(6246003)(186003)(486006)(8936002)(446003)(53936002)(229853002)(6512007)(36756003)(52116002)(102836004)(11346002)(66066001)(76176011)(4744005)(478600001)(316002)(2906002)(1076003)(66946007)(64756008)(66446008)(66476007)(5660300002)(4326008)(99286004)(71200400001)(71190400001)(6436002)(7416002)(66556008);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB4687;H:VI1PR05MB4141.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 1WItz+RTZg/Nu0iunuK7QWWH7MMUJkNnVnMIYWf/fuKthkwSA/1ACrKUSvCiirNc9PBEaAQJ26zVigssjbek6aHXNvDqwdEyeHB6TFpOVNIWjKhc5W7UlPJhe+6oze+t9tOPCW9qdfgimjKTg1/U3BKOeisYTQ5h2K6GZVJ6sCLpkAaRCirt7UCVJZSsVwIGkNQnRYv9jJh7zCxKj7+CMhhfKcULea+THOSx35hIHuLjdHTIzjf2patHf5VIDCr0q8j1bykiqYQbQZ5NIanMtcqRsV/LSq2ZCdKQeIec6jXQq1jyOgChtWL4K/VRhCjKOF1OKi2gbDpQ6pYDOoGaMMCaLkh9roQrXvgJdPIU1cSIfe6TyWWq1i+SfQ+7yy6wjIndZJMqC0F6iTk8FDhdpibJQQcvyvCmUe62ALtnZOo=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <93998CD44856FA42A74BA038E083679E@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b4d6389d-f3f4-4d99-10d3-08d73787c5ff
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2019 13:47:38.0173
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3LeTZNFM5B3TFBrhY13011avW4EvC6NSumKXvAYxbhygp9F41/CzkgYtGvYGczhHjwHXXsmMreUg83s2earFkg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4687
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 06, 2019 at 05:57:17PM +0200, Arnd Bergmann wrote:
> It's never a good idea to put a 1000-byte buffer on the kernel
> stack. The compiler warns about this instance when usnic_ib_log_vf()
> gets inlined into usnic_ib_pci_probe():
>=20
> drivers/infiniband/hw/usnic/usnic_ib_main.c:543:12: error: stack frame si=
ze of 1044 bytes in function 'usnic_ib_pci_probe' [-Werror,-Wframe-larger-t=
han=3D]
>=20
> As this is only called for debugging purposes in the setup path,
> it's trivial to convert to a dynamic allocation.
>=20
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/infiniband/hw/usnic/usnic_ib_main.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Applied to for-next, thanks

Jason