Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2251712ybe; Thu, 12 Sep 2019 06:54:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqyroB0v+tXuSlFTeMk6wVNy8jU67I2FCy7abBcO07fGHKvSK6TKVGYTiGGKCxfLcT+kg5v1 X-Received: by 2002:a17:906:4e15:: with SMTP id z21mr3747483eju.299.1568296464590; Thu, 12 Sep 2019 06:54:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568296464; cv=none; d=google.com; s=arc-20160816; b=cXthHMfvxU8OTB0yKfPp1d/SSFfN2HWxjRkwQKMyWFMH3X/B0E4CJ0MBAevbSxaiT3 cdB+PXTTXtpxFI2uWIGFqWVlxXBF1erHcOqKssP5kSFUXN4FrL3YvlgImb0FSy8ueSJA 5I6Va5otH11inzmWw6tB2wUklZWybwnryAkGW264NVKnC7842mhUZwrauaPgoQwzpsW5 7JZUKrl2X0VYISH4zN8YyfGkgZ0IP8cVhkRWK4A42AVnVbz+229iDDYiVnW4tq005rfq naQnoxiMtQWxVdmWkqt7nD7Pr4BtOxofIrmjchvFEmBJz1It1SPPgu5fMrXHGZnhnc72 4spw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:to:subject:from:references :in-reply-to:message-id:dkim-signature; bh=KU6AEUzEcWurX6mbJ0LIIhHMpx0GSfPDvF/i/o76nqg=; b=q5qMzkhKiWCnXUm4gBNkfyX3AznzaYi2sY+5WAtG/DxB2o2KRNE+43tTvFjtRv9lfC hj41hLgQW7Pr6eEQR2kHSDzHZRKhb5uTuj6KwnvvrnuFFkFj/8vCHeJb7iQV7vpyJXDg iM3PJYCV7gUeYNev0F/WGd+O1JycwZObZNUnLJs6FX0iIPZWzwhNHGRBEQ6OXMOXBppM M4Qe8VXqurpakZ3NboHE8F2KwOXThvwpQvP8/gTj7G0LjYX46fr8drlpSyVq+Eptdb4W mkR2Msqfw9qqVkUlPIrnUicBOUhAcxZGo2j3y3vAHVL6zphwlpa5PQQikdJuWjD8Mhfy 6QAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=aXEScg1F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si9218635eji.341.2019.09.12.06.54.00; Thu, 12 Sep 2019 06:54:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=aXEScg1F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732327AbfILNts (ORCPT + 99 others); Thu, 12 Sep 2019 09:49:48 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:27554 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731209AbfILNtp (ORCPT ); Thu, 12 Sep 2019 09:49:45 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 46Tg9z2Nmwz9tyn3; Thu, 12 Sep 2019 15:49:43 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=aXEScg1F; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id Yf2tTHIzP6K1; Thu, 12 Sep 2019 15:49:43 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 46Tg9z1L1Nz9tyn0; Thu, 12 Sep 2019 15:49:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1568296183; bh=KU6AEUzEcWurX6mbJ0LIIhHMpx0GSfPDvF/i/o76nqg=; h=In-Reply-To:References:From:Subject:To:Cc:Date:From; b=aXEScg1FLqxUKEbEWgWFiv2fc6vmxCKLtKSWvFvLtZc6rlWIeDCgRoqlBGxdpUj/N BkDCF1SFxM/9MF9jHAt9XE4dnHhb8fQ9CFE1USfDeHsODwhCPdr8KMAiJ3ayV37M7C UoBjoktMUeLie6kOllNR4bIr3THcqvu11L55P7LQ= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AF1BF8B93B; Thu, 12 Sep 2019 15:49:44 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id eyoByRudMvqj; Thu, 12 Sep 2019 15:49:44 +0200 (CEST) Received: from pc16032vm.idsi0.si.c-s.fr (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 7C59E8B933; Thu, 12 Sep 2019 15:49:44 +0200 (CEST) Received: by pc16032vm.idsi0.si.c-s.fr (Postfix, from userid 0) id 5EE826B736; Thu, 12 Sep 2019 13:49:44 +0000 (UTC) Message-Id: In-Reply-To: References: From: Christophe Leroy Subject: [PATCH v1 4/4] powerpc/ioremap: warn on early use of ioremap() To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , npiggin@gmail.com, hch@infradead.org Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Thu, 12 Sep 2019 13:49:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Powerpc now has EARLY_IOREMAP. Next step is to convert all early users of ioremap() to early_ioremap(). Add a warning to help locate those users. Signed-off-by: Christophe Leroy --- arch/powerpc/mm/ioremap_32.c | 1 + arch/powerpc/mm/ioremap_64.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/arch/powerpc/mm/ioremap_32.c b/arch/powerpc/mm/ioremap_32.c index f36121f25243..743e11384dea 100644 --- a/arch/powerpc/mm/ioremap_32.c +++ b/arch/powerpc/mm/ioremap_32.c @@ -68,6 +68,7 @@ __ioremap_caller(phys_addr_t addr, unsigned long size, pgprot_t prot, void *call /* * Should check if it is a candidate for a BAT mapping */ + pr_warn("ioremap() called early from %pS. Use early_ioremap() instead\n", caller); err = early_ioremap_range(ioremap_bot - size, p, size, prot); if (err) diff --git a/arch/powerpc/mm/ioremap_64.c b/arch/powerpc/mm/ioremap_64.c index fd29e51700cd..50a99d9684f7 100644 --- a/arch/powerpc/mm/ioremap_64.c +++ b/arch/powerpc/mm/ioremap_64.c @@ -81,6 +81,8 @@ void __iomem *__ioremap_caller(phys_addr_t addr, unsigned long size, if (slab_is_available()) return do_ioremap(paligned, offset, size, prot, caller); + pr_warn("ioremap() called early from %pS. Use early_ioremap() instead\n", caller); + err = early_ioremap_range(ioremap_bot, paligned, size, prot); if (err) return NULL; -- 2.13.3