Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   "Jianyong Wu (Arm Technology China)" <Jianyong.Wu@arm.com>
To:     Marc Zyngier <maz@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        Mark Rutland <Mark.Rutland@arm.com>,
        Will Deacon <Will.Deacon@arm.com>,
        Suzuki Poulose <Suzuki.Poulose@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Steve Capper <Steve.Capper@arm.com>,
        "Kaly Xin (Arm Technology China)" <Kaly.Xin@arm.com>,
        "Justin He (Arm Technology China)" <Justin.He@arm.com>
Subject: RE: [RFC PATCH 3/3] Enable ptp_kvm for arm64
Thread-Topic: [RFC PATCH 3/3] Enable ptp_kvm for arm64
Thread-Index: AQHVXjSmk4aR/CraEk2ZVbEHwQusoKcR7cKAgAyZL9CAAXZNAIADI2mAgAAlXYCAAYC68IABgBYAgAAlaoCAAW7M4A==
Date:   Thu, 12 Sep 2019 09:40:37 +0000
Message-ID: <HE1PR0801MB167691A9F288F65DC6F44156F4B00@HE1PR0801MB1676.eurprd08.prod.outlook.com>
References: <20190829063952.18470-1-jianyong.wu@arm.com>
        <20190829063952.18470-4-jianyong.wu@arm.com>
        <4d04867c-2188-9574-fbd1-2356c6b99b7d@kernel.org>
        <HE1PR0801MB16768ED94EA50010EEF634EAF4BA0@HE1PR0801MB1676.eurprd08.prod.outlook.com>
        <86h85osbzz.wl-maz@kernel.org>
        <HE1PR0801MB16768BE47D3D1F0662DDC3C7F4B70@HE1PR0801MB1676.eurprd08.prod.outlook.com>
        <86blvtsodw.wl-maz@kernel.org>
        <HE1PR0801MB16769814863B26F3B5DC708FF4B60@HE1PR0801MB1676.eurprd08.prod.outlook.com>
        <HE1PR0801MB1676847C0A84473797BF4346F4B10@HE1PR0801MB1676.eurprd08.prod.outlook.com>
 <86ftl3rrxg.wl-maz@kernel.org>
In-Reply-To: <86ftl3rrxg.wl-maz@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Jianyong.Wu@arm.com; 
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-Microsoft-Antispam-Message-Info-Original: CeABzmh2rRvGksFnb2/g8cQJvaSysy2nqvktxmh3oMlzkz/xwi1SfXPh1xIdgUgiK4czhcQd8BL6pueU6Aq3aiW/qrgzD28wJGrrCxUaWo2fnv1w81wrtpbJYcf57ZrDHTemWkfdccQIjLq2wJQglXAKQNcIm2YNkdLPIYSMs9MmMt5Pi+eFZSeyuj3mgksN0BynZbxwHHBqBIHNa3p33GtrKazeuJHmaAeWJ3CO8nSEMAumzogNJ8e4kR3uc9MpHrR2n8Sp3FPb1Lt+jAW7XIMK2vhazmyKPBhXD6hfLjYf4tBye7eGyyAWeZjjcreFvlfI98++v3jEy+vO90AuhkvqmjenycWOH8itPIpaVKGLeVbHT95KjJ38d1RUT2dErL6EWnZTDSMPgAZ+ciegy/70nRF2n7IiU5foejuwGko=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2076
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Jianyong.Wu@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT025.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(396003)(39860400002)(376002)(346002)(136003)(13464003)(189003)(199004)(40434004)(46406003)(23726003)(229853002)(25786009)(6116002)(3846002)(97756001)(6862004)(9686003)(22756006)(6246003)(126002)(476003)(55016002)(5024004)(14444005)(450100002)(4326008)(99286004)(5660300002)(50466002)(86362001)(356004)(47776003)(336012)(11346002)(316002)(54906003)(446003)(7736002)(63350400001)(14454004)(102836004)(53546011)(6506007)(7696005)(76176011)(186003)(74316002)(26005)(486006)(26826003)(305945005)(33656002)(508600001)(81156014)(8746002)(8936002)(2906002)(52536014)(8676002)(81166006)(66066001)(76130400001)(70586007)(70206006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB5412;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 48aa215f-2f7e-41f5-f0e8-08d737654497
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:AM0PR08MB5412;
X-Forefront-PRVS: 01583E185C
X-Microsoft-Antispam-Message-Info: 5LQxpOOa8s9sWg/vquL+SedMK//Il/cKBdhEHI5qAAOHPPdkQZKScK5OycjkCJiPRedRky/nzxBUuTu/rBUb2po2U9UaD18sfmHBlaimrMVNsMLsUCCzc1Um1Ah6WHrUoSAO2Pzt2Y+aLiaMqp5QldMNkTXiarDol+VK6R+J8l50drFlhz94BtiD4bR3uaWupNum4DqAGdglUcoRpO9n10Izq8+9dzw2WDBzSoTLygwln5U52vYPl1qxTuPcWl9AigLZSa7xKeVWpRYfV62cx1ZtLUgAO4u6ZwznXoBqSKPoViUyAl5xVWibsC1yxYuO3AtV4y3V5kbDb9xlUfAeRWUQ1dNyxtnurmS7+JHgYW2JueAlFl4MDwsz4/dSFbbZsarRDiyCdqjm2TgS90u122qYccRd/YLtmueS6TQhfn4=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2019 09:40:47.6543
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9dc2949e-3384-4f1c-4751-08d737654a7f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5412
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Marc,

> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: Wednesday, September 11, 2019 7:31 PM
> To: Jianyong Wu (Arm Technology China) <Jianyong.Wu@arm.com>
> Cc: netdev@vger.kernel.org; pbonzini@redhat.com;
> sean.j.christopherson@intel.com; richardcochran@gmail.com; Mark Rutland
> <Mark.Rutland@arm.com>; Will Deacon <Will.Deacon@arm.com>; Suzuki
> Poulose <Suzuki.Poulose@arm.com>; linux-kernel@vger.kernel.org; Steve
> Capper <Steve.Capper@arm.com>; Kaly Xin (Arm Technology China)
> <Kaly.Xin@arm.com>; Justin He (Arm Technology China)
> <Justin.He@arm.com>
> Subject: Re: [RFC PATCH 3/3] Enable ptp_kvm for arm64
>
> On Wed, 11 Sep 2019 11:06:18 +0100,
> "Jianyong Wu (Arm Technology China)" <Jianyong.Wu@arm.com> wrote:
> >
> > Hi Marc,
> >
> > I think there are three points for the migration issue of ptp_kvm,
> > where a VM using ptp_kvm migrates to a host without ptp_kvm support.
> >
> > First: how does it impact the VM having migrated?
> > I run a VM with ptp_kvm support in guest but not support in host. the
> > ptp0 will return 0 when get time from it which can't pass the check of
> > chrony, then chrony will choose another clocksource.
> > From this point, VM will only get lost in precision of time sync.
>
> "only" is a bit of an understatement. Once the guest has started relying =
on a
> service, it seems rather harsh to pretend this service doesn't exist anym=
ore.
> It could well be that the VM cannot perform its function if the precision=
 is not
> good enough.
>
> The analogy is the Spectre-v2 mitigation, which is implemented as a hyper=
call.
> Nothing will break if you migrate to a host that doesn't support the miti=
gation,
> but the guest will now be unsafe. Is that acceptable? the answer is of co=
urse
> "no".
>
> > Second: how to check the failure of the ptp kvm service when there is
> > no ptp kvm service, hypercall will go into default ops, so we can
> > check the return value which can inform us the failure.
>
> Sure. But that's still an issue. The VM relied on the service, and the se=
rvice
> isn't available anymore.
>
> > Third: how to inform VMM
> > There is ioctl cmd call "KVM_CHECK_EXTENSION" in kvm, which may do
> > that thing. Accordingly, qemu should be offered the support which will
> > block us.  We can try to add this support in kvm but we are not sure
> > the response from qemu side.
>
> It doesn't matter whether QEMU implements that check or . The important
> thing is that we give userspace a way to check this for this, and having =
a
> capability that can be checked against is probably the right thing to do.

Ok, I agree.
Adding a new capability item under "KVM_CHECK_EXTENSION" in kvm for ptp_kvm=
 will do and Using ioctl in userspace can check if the ptp service is avail=
able.
I will append this patch in this patch serial.

Thanks
Jianyong Wu

>
> Thanks,
>
>       M.
>
> --
> Jazz is not dead, it just smells funny.
IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.