Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2513480ybe; Thu, 12 Sep 2019 10:30:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqxw/9AV3kkdN+FJAiX4d6hg2PcupIOnN4nAvfyDhwdNiQrtOlIe4HCFM3MS9NqD6WtDpDeO X-Received: by 2002:a17:906:f2d3:: with SMTP id gz19mr35593975ejb.306.1568309436793; Thu, 12 Sep 2019 10:30:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568309436; cv=none; d=google.com; s=arc-20160816; b=a5hqq9+DgR1puxyZZTNhl6z7GwPF1CFTbCWaW3vatf9sZnO2eCv8CSut7AbouD7D0F Xogn9BBWM+Pu7Kc1217wwjs1ZFVH6cz8dTK5byCCSsYBuIW9T7fMRZ2wafYFL35Qun5p 0vnq0fCWmYu+0MgixPHowqyWrV+mEwaFC5ma6Pd7VXWD4TeO6xyP/NAm0Muf8r2t4gnq VtBDnn5ePYknrpKgA8hKKQLFSk9Df4P/J74n5kgda3HMs0qDOuEeWIBYEY23TqfMh6j0 4RPgBoMqnMEyaLHGtz+6Sb9hyV0+pIJY6yzM7R/bDmbnLF0AkfdVGluAFjZPaufq10PU XSEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=qItl474ydr9PYYUpQzvLDogUuRN+mOWlYQby17fM1iw=; b=kFJxSLkoAiSzUiNj5ilE0K+phdAUhfErKKpssudmae5Yyv7Lgmoy8LaZeR9GSRplAe jsDAWdl2vnleB52BqKc0z+vsSA4ltrfrV0bKm+/vKYVOva21RWEG1sy9MxIjgOPggFUR PGfA38LuBbfqtz8AOC9zXsfiw7+rBbM0h2xUHtXNd1ZDCygBBTQj0EhHR8Y2sJlrhwH7 6K1V+eT2buRZN6HKEM8UzOp4rFwX6WPSKQujzHE7f5zJ9vwndL7RWNJX4ER6V7AJp62H LqaLnIp5yUicGj90+aJu/9lKgchoqJl9bjbVNc/w0BekkvrEr1ZPEg5F5289iYuipKvm uiOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 52si15120128edz.413.2019.09.12.10.30.13; Thu, 12 Sep 2019 10:30:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731846AbfILM4j (ORCPT + 99 others); Thu, 12 Sep 2019 08:56:39 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:57034 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731772AbfILM4j (ORCPT ); Thu, 12 Sep 2019 08:56:39 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 18464246-1500050 for multiple; Thu, 12 Sep 2019 13:56:36 +0100 From: Chris Wilson To: intel-gfx@lists.freedesktop.org, torvalds@linux-foundation.org Cc: Martin.Wilck@suse.com, MKoutny@suse.com, leho@kraav.com, tiwai@suse.de, linux-kernel@vger.kernel.org, Chris Wilson , Lionel Landwerlin , Tvrtko Ursulin , Jani Nikula , Joonas Lahtinen , stable@vger.kernel.org Subject: [PATCH] Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()" Date: Thu, 12 Sep 2019 13:56:34 +0100 Message-Id: <20190912125634.29054-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.23.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The userptr put_pages can be called from inside try_to_unmap, and so enters with the page lock held on one of the object's backing pages. We cannot take the page lock ourselves for fear of recursion. Reported-by: Lionel Landwerlin Reported-by: Martin Wilck Reported-by: Leo Kraav Fixes: aa56a292ce62 ("drm/i915/userptr: Acquire the page lock around set_page_dirty()") References: https://bugzilla.kernel.org/show_bug.cgi?id=203317 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: Jani Nikula Cc: Joonas Lahtinen Cc: stable@vger.kernel.org --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c index 74da35611d7c..11b231c187c5 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c @@ -672,15 +672,7 @@ i915_gem_userptr_put_pages(struct drm_i915_gem_object *obj, for_each_sgt_page(page, sgt_iter, pages) { if (obj->mm.dirty) - /* - * As this may not be anonymous memory (e.g. shmem) - * but exist on a real mapping, we have to lock - * the page in order to dirty it -- holding - * the page reference is not sufficient to - * prevent the inode from being truncated. - * Play safe and take the lock. - */ - set_page_dirty_lock(page); + set_page_dirty(page); mark_page_accessed(page); put_page(page); -- 2.23.0