Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAD56B7euf1kQpwOYiq-he8HveKKzkGdf8_-izEVfwa=QH24a3g@mail.gmail.com>
 <33ec2a52-91aa-6c4a-d900-1725f2970975@xilinx.com>
In-Reply-To: <33ec2a52-91aa-6c4a-d900-1725f2970975@xilinx.com>
From:   Paul Thomas <pthomas8589@gmail.com>
Date:   Thu, 12 Sep 2019 12:38:43 -0400
Message-ID: <CAD56B7dvKtqQV9hkKEKB7VgoE8hqQGqMxHZiCXxg0sejUpsNCg@mail.gmail.com>
Subject: Re: Regression: commit c9712e333809 breaks xilinx_uartps
To:     Michal Simek <michal.simek@xilinx.com>
Cc:     Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
        Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sasha Levin <sashal@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > ---
> >  drivers/tty/serial/xilinx_uartps.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/tty/serial/xilinx_uartps.c
> > b/drivers/tty/serial/xilinx_uartps.c
> > index 9dcc4d855ddd..ece7f6caa994 100644
> > --- a/drivers/tty/serial/xilinx_uartps.c
> > +++ b/drivers/tty/serial/xilinx_uartps.c
> > @@ -1565,6 +1565,8 @@ static int cdns_uart_probe(struct platform_device *pdev)
> >
> >         cdns_uart_data->pclk = devm_clk_get(&pdev->dev, "pclk");
> >         if (PTR_ERR(cdns_uart_data->pclk) == -EPROBE_DEFER) {
> > +               /* If we end up defering then set uartps_major back to 0 */
> > +               uartps_major = 0;
> >                 rc = PTR_ERR(cdns_uart_data->pclk);
> >                 goto err_out_unregister_driver;
> >         }
> >
>
> I expect that this can be problematic for all failures in probe.
> What about this?
Makes sense, this worked for me. Although, I think the patch is
malformed by the email line lengths.

-Paul

> Just setting up global major number if first instance
> pass.
> Also cleanup should be likely done in remove function too.
>
>
>  diff --git a/drivers/tty/serial/xilinx_uartps.c
> b/drivers/tty/serial/xilinx_uartps.c
>  index f145946f659b..c1550b45d59b 100644
>  --- a/drivers/tty/serial/xilinx_uartps.c
>  +++ b/drivers/tty/serial/xilinx_uartps.c
>  @@ -1550,7 +1550,6 @@ static int cdns_uart_probe(struct platform_device
> *pdev)
>                  goto err_out_id;
>          }
>
>  -       uartps_major = cdns_uart_uart_driver->tty_driver->major;
>          cdns_uart_data->cdns_uart_driver = cdns_uart_uart_driver;
>
>          /*
>  @@ -1680,6 +1679,7 @@ static int cdns_uart_probe(struct platform_device
> *pdev)
>                  console_port = NULL;
>   #endif
>
>  +       uartps_major = cdns_uart_uart_driver->tty_driver->major;
>          cdns_uart_data->cts_override =
> of_property_read_bool(pdev->dev.of_node,
>
> "cts-override");
>          return 0;
>
> Thanks,
> Michal