Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2591261ybe; Thu, 12 Sep 2019 11:45:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqxGkDzex6EtA42s83sWGHA5V/2ujW/Ua/f7Uouq272DT5gC2gZdh3whMqfvUxJxMlNG/b3n X-Received: by 2002:a50:8dcb:: with SMTP id s11mr19544449edh.27.1568313959767; Thu, 12 Sep 2019 11:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568313959; cv=none; d=google.com; s=arc-20160816; b=tQuGR5zDQR/78IQx/G+xCmfl8W3TZR9SLf4YEBoB4WAqITFzvKYSsMLEYsTpH3r+4f eQFraSsvAJnBWKPJmeqj8MfuDXErBwpHWna9mNtBgpFFGWYpSR0ie1B13e69EtIULDuT fTdy9MGEZKpGbB/6tGLnLi0mNV0SsXnLJ0cIlxG0a1wUVIb1UApdA9s7+K1/loQYagMw FiJjdm5k2YrSGMiFQ4ydtOC7ntPozbbzoRWQ56I00avfknZFRAkRET7RhnpVzx1F4AGX L5bcJXVKvTesPamq2+5p8vJLGmPKK+lCueX3fuQIBKEWSnNQAMBZpwDeXmHKfWU6eryJ u1YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=aH2g8DtDzkArxVJPBpxcFlnrIHiwGVofHTI/sIITSgI=; b=wnC9uFLJ1/s5edW5haCLb/pfwrf0yG3mQ+Kypg/TDk1GjdVp88MV77OBTekreEXR++ 8EFw7NEy8qka7/ZdM968GktazcZ33SU2wnbEY13gEDQk8rqBs6HXHqKt7zUnUvJKvDyi FQVqrfTq9nV3hOTud+DmkKWt5CJOGf5GP2SWkC/ZkcOSsZgOp1QnhqRov8Z3IjleghA9 kAeMOzGh4EUrtH68HtW7A5xugGSjENMwW1BV5uRjLZ4sQbq9prSCO9eVPEIHt0d7c5D6 nhTtEyULRC80Qi4FxWMkxRAwSo0fTcUsYhbjNY7rVE4NkK+9KjCeYgIcUjrtzJx6U5iR 0thA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f33si16289986edb.281.2019.09.12.11.45.34; Thu, 12 Sep 2019 11:45:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730914AbfILQoo (ORCPT + 99 others); Thu, 12 Sep 2019 12:44:44 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:52384 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725972AbfILQoo (ORCPT ); Thu, 12 Sep 2019 12:44:44 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 43CC7E7633E1EFF97E39; Fri, 13 Sep 2019 00:44:40 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Fri, 13 Sep 2019 00:44:34 +0800 From: zhong jiang To: CC: , , , , Subject: [PATCH 1/3] brcmsmac: Remove unneeded variable and make function to be void Date: Fri, 13 Sep 2019 00:41:30 +0800 Message-ID: <1568306492-42998-2-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1568306492-42998-1-git-send-email-zhongjiang@huawei.com> References: <1568306492-42998-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org brcms_c_set_mac do not need return value to cope with different cases. And change functon return type to void. Signed-off-by: zhong jiang --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c index 080e829..ddc4d47 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c @@ -3776,17 +3776,14 @@ static void brcms_c_set_ps_ctrl(struct brcms_c_info *wlc) * Write this BSS config's MAC address to core. * Updates RXE match engine. */ -static int brcms_c_set_mac(struct brcms_bss_cfg *bsscfg) +static void brcms_c_set_mac(struct brcms_bss_cfg *bsscfg) { - int err = 0; struct brcms_c_info *wlc = bsscfg->wlc; /* enter the MAC addr into the RXE match registers */ brcms_c_set_addrmatch(wlc, RCM_MAC_OFFSET, wlc->pub->cur_etheraddr); brcms_c_ampdu_macaddr_upd(wlc); - - return err; } /* Write the BSS config's BSSID address to core (set_bssid in d11procs.tcl). -- 1.7.12.4