From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [RFC][PATCH 7/7] RTC subsystem, test device/driver
Date: Mon, 26 Dec 2005 18:45:34 -0500
User-Agent: KMail/1.9.1
Cc: linux-kernel@vger.kernel.org
References: <20051226195913.6f680634@inspiron>
In-Reply-To: <20051226195913.6f680634@inspiron>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200512261845.34731.dtor_core@ameritech.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 787
Lines: 28

On Monday 26 December 2005 13:59, Alessandro Zummo wrote:
> +struct platform_device test_dev_zero = {
> +	.name	= "rtc-test",
> +	.id	= 0,
> +	.dev.release = test_release,
> +};
> +
> +struct platform_device test_dev_one = {
> +	.name	= "rtc-test",
> +	.id	= 1,
> +	.dev.release = test_release,
> +};
> +

You should never ever statically allicate devices that can be unregistered.
Guess what will happen if one does this:

	rmmod rtc_test  < /sys/class/rtc/rtcX/date

where rctX is class device created by rtc-test0 or rtc-test1.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/