Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Sep 2019 16:55:15 -0400 (EDT)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
cc:     Kernel development list <linux-kernel@vger.kernel.org>
Subject: [PATCH] checkpatch.pl: Don't complain about nominal authors if there
 isn't one
Message-ID: <Pine.LNX.4.44L0.1909121651180.1305-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
nominal patch author" if there is no nominal patch author.  Without
this change, checkpatch always gives me the following warning:

	WARNING: Missing Signed-off-by: line by nominal patch author ''

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>

---

 scripts/checkpatch.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: usb-devel/scripts/checkpatch.pl
===================================================================
--- usb-devel.orig/scripts/checkpatch.pl
+++ usb-devel/scripts/checkpatch.pl
@@ -6673,7 +6673,7 @@ sub process {
 		if ($signoff == 0) {
 			ERROR("MISSING_SIGN_OFF",
 			      "Missing Signed-off-by: line(s)\n");
-		} elsif (!$authorsignoff) {
+		} elsif ($author ne '' && !$authorsignoff) {
 			WARN("NO_AUTHOR_SIGN_OFF",
 			     "Missing Signed-off-by: line by nominal patch author '$author'\n");
 		}