Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 13 Sep 2019 11:24:15 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Brad Campbell <lists2009@fnarfbargle.com>
Cc:     linux-kernel@vger.kernel.org, michael.jamet@intel.com,
        YehezkelShB@gmail.com
Subject: Re: Thunderbolt DP oddity on v5.2.9 on iMac 12,2
Message-ID: <20190913082415.GA28281@lahna.fi.intel.com>
References: <7c9474d2-d948-4d1d-6f7b-94335b8b1f15@fnarfbargle.com>
 <20190828102342.GT3177@lahna.fi.intel.com>
 <e3a8fa91-2cfd-76a4-641c-610c32122833@fnarfbargle.com>
 <20190828131943.GZ3177@lahna.fi.intel.com>
 <be32b369-b013-cca8-5475-9b56acaa3e18@fnarfbargle.com>
 <20190903101325.GC2691@lahna.fi.intel.com>
 <71e34f9e-8e0d-f5f2-bc55-006aeb8a383b@fnarfbargle.com>
 <20190903115527.GE2691@lahna.fi.intel.com>
 <30fe86c0-e4f9-e852-a4d8-7b8263b373ef@fnarfbargle.com>
 <20190903133319.GG2691@lahna.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190903133319.GG2691@lahna.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Brad,

On Tue, Sep 03, 2019 at 04:33:23PM +0300, Mika Westerberg wrote:
> On Tue, Sep 03, 2019 at 08:54:02PM +0800, Brad Campbell wrote:
> > On 3/9/19 7:55 pm, Mika Westerberg wrote:
> > > On Tue, Sep 03, 2019 at 07:11:32PM +0800, Brad Campbell wrote:
> > > 
> > > I think the problem is that for some reason, probably because this is
> > > first generation hardware with all the bugs included, you cannot read
> > > the second dword from DP adapter path config space (you can write it
> > > though).
> > > 
> > > I've updated the patch so that it reads only the first dword when it
> > > discovers paths and also when it disables them. Can you try it out and
> > > see if it makes a difference? This should also get rid of the warnings
> > > you get.
> > > 
> > 
> > It would seem so. Now I get 3 heads on a cold or warm boot and no warnings
> > in the log, so it looks like that did the job. I've attached the dmesg from
> > the last cold boot for reference.
> 
> Great, thanks for checking. I will create a proper patch and submit
> upstream hopefully later this week or early next.

Unfortunately I did not have time to create a proper patch yet. I've
been busy with other things currently. Since merge window opens next
week this would have to wait until it closes anyway. I'm trying to get
this as part of a patch series I plan to submit after v5.4-rc1 is
released.