Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Patch 02/13] media: am437x-vpfe: Fix missing first line
To:     Benoit Parrot <bparrot@ti.com>
Cc:     Prabhakar Lad <prabhakar.csengg@gmail.com>,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20190909162743.30114-1-bparrot@ti.com>
 <20190909162743.30114-3-bparrot@ti.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <018a5f55-a750-c86d-da82-2b7c586cb33e@xs4all.nl>
Date:   Fri, 13 Sep 2019 15:00:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190909162743.30114-3-bparrot@ti.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/9/19 6:27 PM, Benoit Parrot wrote:
> Previous generation of this driver were hard coded to handle
> encoder/decoder were the first line never contains any data and

were -> where

> was therefore always skipped, however when dealing with actual
> camera sensor the first line is always present.

sensor -> sensors

Regards,

	Hans

> 
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> ---
>  drivers/media/platform/am437x/am437x-vpfe.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
> index ab959d61f9c9..0ecb75bf5abd 100644
> --- a/drivers/media/platform/am437x/am437x-vpfe.c
> +++ b/drivers/media/platform/am437x/am437x-vpfe.c
> @@ -345,13 +345,9 @@ static void vpfe_ccdc_setwin(struct vpfe_ccdc *ccdc,
>  	if (frm_fmt == CCDC_FRMFMT_INTERLACED) {
>  		vert_nr_lines = (image_win->height >> 1) - 1;
>  		vert_start >>= 1;
> -		/* Since first line doesn't have any data */
> -		vert_start += 1;
>  		/* configure VDINT0 */
>  		val = (vert_start << VPFE_VDINT_VDINT0_SHIFT);
>  	} else {
> -		/* Since first line doesn't have any data */
> -		vert_start += 1;
>  		vert_nr_lines = image_win->height - 1;
>  		/*
>  		 * configure VDINT0 and VDINT1. VDINT1 will be at half
>