Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp782070ybe; Fri, 13 Sep 2019 06:18:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwCKgvcAb/eIMinCOHyvU+UFIjxF9PWmzNYBUa/9fxr3tU0vY3BpAIINVekmAiqT3eONWsr X-Received: by 2002:a05:6402:658:: with SMTP id u24mr48850169edx.102.1568380725467; Fri, 13 Sep 2019 06:18:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568380725; cv=none; d=google.com; s=arc-20160816; b=LLYx67kToWG+4Gdn2Wr/XHu5hh2/ZlvRNCjl5704EDU44HA3j27ros5w08VOQPxD5F X5gEoRwX215LEPl0ejAE37CqcHKPZdKrdjES7AkNw1Vn2lKTzf4ESB9uTeGl9j+J87hF aBztJ2Rms3ABnbUvR9jf+XiS1IJiCxKUB/3eH46ZtQnEi8xDTPGmbyf06GOTv1GZJyzk FWR+9UHPB9Y9Dxcq/vWS4RTBTmpMPRBR3U42Mil6Rl4rOlZCAz4WTTaj5Fa7G0ZHjbqs 9ABTGQn/6hPwJFhfRvF3FIIa4tFgSbALyu8z3DsFYq9Dm1Lpl6am+zCcn5KjT81mzCXM Rbgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ImH3x6/ud2SkIuCtf3OJbpa1JXFF5xkBMbykRVnA3Wg=; b=CR4AdGzAaPUk1TveOUauXefVvhspUfrsf767gQBcWz4aVS7uZMP1RsIzRuDdpeeeHn ptX+HKw4xDAH+6Z5lpqM96I93RtDnjVdwp5yoIUyk0WerOfbV5SqkrRBITKAp1xI68du 7jUw2sBLeQ4UTlC2aQssWP7zX0pxRI1ln82VL6mugvBO0cJEpc/JM/e8X8IC1niFaY/K HLhoDGLNIBMAqq6JlHwC8BqWLnPfdpWSF+C9i3h/oNLbXhJ6yUR+K447DQq4Fok8nQb2 NghJpqkYOVCw2Yf8l6M4e1Mf8D6Y4aVOBAk33XV/LTLMuwK5Faxw1/n+SbRijCl7P/PU w71Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kUgCROXY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3si9427299ejm.109.2019.09.13.06.18.22; Fri, 13 Sep 2019 06:18:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kUgCROXY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389730AbfIMNPo (ORCPT + 99 others); Fri, 13 Sep 2019 09:15:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:41954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389726AbfIMNPi (ORCPT ); Fri, 13 Sep 2019 09:15:38 -0400 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0524214AE; Fri, 13 Sep 2019 13:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568380537; bh=glaAkWpahE1sgKI34qcF2w15f41BDvcFRLMcHeDjOR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kUgCROXY4v5K0rVtIKawwwOB8IHvjCq9aLaibZKj86DcLowA3A5sPhcO0IIBlGP/T XHyi3wCmIPO0Nexq8KWdwFPPvg3yklfVJoI7csMLGt304W77aHk+lDuQFAimaxc512 OWGRbaddec4ZaFYuQn/PJhezL6i8bSPVgWoooZ7g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 4.19 090/190] iio: adc: exynos-adc: Use proper number of channels for Exynos4x12 Date: Fri, 13 Sep 2019 14:05:45 +0100 Message-Id: <20190913130606.807045201@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190913130559.669563815@linuxfoundation.org> References: <20190913130559.669563815@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 103cda6a3b8d2c10d5f8cd7abad118e9db8f4776 ] Exynos4212 and Exynos4412 have only four ADC channels so using "samsung,exynos-adc-v1" compatible (for eight channels ADCv1) on them is wrong. Add a new compatible for Exynos4x12. Signed-off-by: Krzysztof Kozlowski Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- .../bindings/iio/adc/samsung,exynos-adc.txt | 4 +++- drivers/iio/adc/exynos_adc.c | 17 +++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt index a10c1f89037de..e1fe02f3e3e9c 100644 --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.txt @@ -11,11 +11,13 @@ New driver handles the following Required properties: - compatible: Must be "samsung,exynos-adc-v1" - for exynos4412/5250 controllers. + for Exynos5250 controllers. Must be "samsung,exynos-adc-v2" for future controllers. Must be "samsung,exynos3250-adc" for controllers compatible with ADC of Exynos3250. + Must be "samsung,exynos4212-adc" for + controllers compatible with ADC of Exynos4212 and Exynos4412. Must be "samsung,exynos7-adc" for the ADC in Exynos7 and compatibles Must be "samsung,s3c2410-adc" for diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c index 41da522fc6735..1ca2c4d39f878 100644 --- a/drivers/iio/adc/exynos_adc.c +++ b/drivers/iio/adc/exynos_adc.c @@ -115,6 +115,7 @@ #define MAX_ADC_V2_CHANNELS 10 #define MAX_ADC_V1_CHANNELS 8 #define MAX_EXYNOS3250_ADC_CHANNELS 2 +#define MAX_EXYNOS4212_ADC_CHANNELS 4 #define MAX_S5PV210_ADC_CHANNELS 10 /* Bit definitions common for ADC_V1 and ADC_V2 */ @@ -271,6 +272,19 @@ static void exynos_adc_v1_start_conv(struct exynos_adc *info, writel(con1 | ADC_CON_EN_START, ADC_V1_CON(info->regs)); } +/* Exynos4212 and 4412 is like ADCv1 but with four channels only */ +static const struct exynos_adc_data exynos4212_adc_data = { + .num_channels = MAX_EXYNOS4212_ADC_CHANNELS, + .mask = ADC_DATX_MASK, /* 12 bit ADC resolution */ + .needs_adc_phy = true, + .phy_offset = EXYNOS_ADCV1_PHY_OFFSET, + + .init_hw = exynos_adc_v1_init_hw, + .exit_hw = exynos_adc_v1_exit_hw, + .clear_irq = exynos_adc_v1_clear_irq, + .start_conv = exynos_adc_v1_start_conv, +}; + static const struct exynos_adc_data exynos_adc_v1_data = { .num_channels = MAX_ADC_V1_CHANNELS, .mask = ADC_DATX_MASK, /* 12 bit ADC resolution */ @@ -492,6 +506,9 @@ static const struct of_device_id exynos_adc_match[] = { }, { .compatible = "samsung,s5pv210-adc", .data = &exynos_adc_s5pv210_data, + }, { + .compatible = "samsung,exynos4212-adc", + .data = &exynos4212_adc_data, }, { .compatible = "samsung,exynos-adc-v1", .data = &exynos_adc_v1_data, -- 2.20.1