Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp821572ybe; Fri, 13 Sep 2019 06:54:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8gSvHaG5PGS5ydPCo4zl28JgbtPGCjv+y61tYNFVl6BQrHNxtAWNPRwwofP6v/DD9K28f X-Received: by 2002:a50:934c:: with SMTP id n12mr40227792eda.12.1568382892031; Fri, 13 Sep 2019 06:54:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568382892; cv=none; d=google.com; s=arc-20160816; b=RmF7tZNxFLkE25zBiAdINeG+7gW7VTGgKn/2Xvw1Lsh6adZlJyiQZw36Zjb2dL8E/V eADcBhk0gk6TYwHhTlHt7qdaH5YIfAfmKBGoURI6Bs3xjddM/j2YAC4W/Dw94SRaGxQC sVJkpZQ7Guz++hIYa+xz190FOZXiKwuoB9V8loMjNJaudQ2y+WDVsRy9i3C5O8yvxxTC q/Ivc7dj0XvXerHvfB58YgU6tIiJrgKTe3vCasQrKzMbpFaCmmLymbaTa9WO88gr41qT mmlwMEj23Ypn4Ig04QC1nv2ew9ZhYl0CN7diqXKiZAbtzGk/sSFxWwktgg0twu421Khm 4Cyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date; bh=u5tssj5pdV9jrY9JJGgo8VnBpk9fV2ZSi+6En/8Y3oM=; b=x184XmvrKlrJXoC5jhqSeWjumFUI9T1EdYIYLbc9izr3uIIb7ZIoQIvG5ir69Waom9 8Tsn1w7M2FDnPCtytpaaz0z630B9DwlrlRe3cwmtgqwKrlF4T4Oq20JaSBZEEdxBPLOz vSgGAJu3KNE7dp/crWfDa9kRw402zOtOl7AwZ9K8r7s901vHnArS4bwYKrlygETLuQ6P 6Tal3rEyVAck0491E8EXuoqwxSAK/N+9lGok/1DPqCGwxbA2Ge/ZDiV9ZDA/1E8oKBAH XYuMbA6hkgS8OFQye6E5YA8XXsliAaNpR2LTScdRaRqjjomF7E2cr5fMHdWqvFhrJ4zZ Gu0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si14504406ejz.328.2019.09.13.06.54.28; Fri, 13 Sep 2019 06:54:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391325AbfIMNuV (ORCPT + 99 others); Fri, 13 Sep 2019 09:50:21 -0400 Received: from mga05.intel.com ([192.55.52.43]:7151 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388639AbfIMNuU (ORCPT ); Fri, 13 Sep 2019 09:50:20 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2019 06:50:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="176286060" Received: from ltudorx-wtg.ger.corp.intel.com (HELO localhost) ([10.252.37.39]) by orsmga007.jf.intel.com with ESMTP; 13 Sep 2019 06:50:14 -0700 Date: Fri, 13 Sep 2019 14:50:11 +0100 From: Jarkko Sakkinen To: linux-integrity@vger.kernel.org, stable@vger.kernel.org, Roberto Sassu , Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH] tpm: Call tpm_put_ops() when the validation for @digests fails Message-ID: <20190913135011.GH7412@linux.intel.com> References: <20190910142437.20889-1-jarkko.sakkinen@linux.intel.com> <20190910151121.3tgzwuhrroog5dvb@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190910151121.3tgzwuhrroog5dvb@cantor> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 10, 2019 at 08:11:21AM -0700, Jerry Snitselaar wrote: > On Tue Sep 10 19, Jarkko Sakkinen wrote: > > The chip is not released when the validation for @digests fails. Add > > tpm_put_ops() to the failure path. > > > > Cc: stable@vger.kernel.org > > Reported-by: Roberto Sassu > > Signed-off-by: Jarkko Sakkinen > > Reviewed-by: Jerry Snitselaar Roberto, can you just squash this fix with yours to a single patch and send a new patch version? You can add suggested-by tag from me to v4. /Jarkko