Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Pankaj Dubey" <pankaj.dubey@samsung.com>
To:     "'Gustavo Pimentel'" <Gustavo.Pimentel@synopsys.com>,
        <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc:     <jingoohan1@gmail.com>, <lorenzo.pieralisi@arm.com>,
        <bhelgaas@google.com>, "'Anvesh Salveru'" <anvesh.s@samsung.com>
In-Reply-To: <DM6PR12MB4010B4CC5DD11D3607D157ABDAB00@DM6PR12MB4010.namprd12.prod.outlook.com>
Subject: RE: [PATCH 1/2] PCI: dwc: Add support to disable GEN3 equalization
Date:   Fri, 13 Sep 2019 16:23:41 +0530
Message-ID: <002701d56a21$82a4c880$87ee5980$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHkrftp/qePsooAO7EnIOhukMFsOwG9FaICAkQIfYem6t2S8A==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20190910122514epcas5p4f00c0f999333dd7707c0a353fd06b57f@epcas5p4.samsung.com>
        <1568118302-10505-1-git-send-email-pankaj.dubey@samsung.com>
        <DM6PR12MB4010B4CC5DD11D3607D157ABDAB00@DM6PR12MB4010.namprd12.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> -----Original Message-----
> From: Gustavo Pimentel <Gustavo.Pimentel=40synopsys.com>
> Sent: Thursday, September 12, 2019 7:52 PM
> To: Pankaj Dubey <pankaj.dubey=40samsung.com>; linux-pci=40vger.kernel.or=
g;
> linux-kernel=40vger.kernel.org
> Cc: jingoohan1=40gmail.com; Gustavo.Pimentel=40synopsys.com;
> lorenzo.pieralisi=40arm.com; bhelgaas=40google.com; Anvesh Salveru
> <anvesh.s=40samsung.com>
> Subject: RE: =5BPATCH 1/2=5D PCI: dwc: Add support to disable GEN3 equali=
zation
>=20
> Hi,
>=20
> On Tue, Sep 10, 2019 at 13:25:1, Pankaj Dubey <pankaj.dubey=40samsung.com=
>
> wrote:
>=20
> > From: Anvesh Salveru <anvesh.s=40samsung.com>
> >
> > In some platforms, PCIe PHY may have issues which will prevent linkup
> > to happen in GEN3 or high speed. In case equalization fails, link will
> > fallback to GEN1.
> >
> > Designware controller has support for disabling GEN3 equalization if
> > required. This patch enables the designware driver to disable the PCIe
> > GEN3 equalization by writing into PCIE_PORT_GEN3_RELATED.
>=20
> s/Designware/DesignWare
> s/designware/DesignWare
>=20
> >
> > Platform drivers can disable equalization by setting the dwc_pci_quirk
> > flag DWC_EQUALIZATION_DISABLE.
> >
> > Signed-off-by: Anvesh Salveru <anvesh.s=40samsung.com>
> > Signed-off-by: Pankaj Dubey <pankaj.dubey=40samsung.com>
> > ---
> >  drivers/pci/controller/dwc/pcie-designware.c =7C 7 +++++++
> > drivers/pci/controller/dwc/pcie-designware.h =7C 7 +++++++
> >  2 files changed, 14 insertions(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c
> > b/drivers/pci/controller/dwc/pcie-designware.c
> > index 7d25102..bf82091 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > =40=40 -466,4 +466,11 =40=40 void dw_pcie_setup(struct dw_pcie *pci)
> >  		break;
> >  	=7D
> >  	dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val);
> > +
> > +	val =3D dw_pcie_readl_dbi(pci, PCIE_PORT_GEN3_RELATED);
> > +
> > +	if (pci->dwc_pci_quirk & DWC_EQUALIZATION_DISABLE)
> > +		val =7C=3D PORT_LOGIC_GEN3_EQ_DISABLE;
> > +
> > +	dw_pcie_writel_dbi(pci, PCIE_PORT_GEN3_RELATED, val);
> >  =7D
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.h
> > b/drivers/pci/controller/dwc/pcie-designware.h
> > index ffed084..a1453c5 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.h
> > +++ b/drivers/pci/controller/dwc/pcie-designware.h
> > =40=40 -29,6 +29,9 =40=40
> >  =23define LINK_WAIT_MAX_IATU_RETRIES	5
> >  =23define LINK_WAIT_IATU			9
> >
> > +/* Parameters for PCIe Quirks */
> > +=23define DWC_EQUALIZATION_DISABLE	0x1
> > +
> >  /* Synopsys-specific PCIe configuration registers */
> >  =23define PCIE_PORT_LINK_CONTROL		0x710
> >  =23define PORT_LINK_MODE_MASK		GENMASK(21, 16)
> > =40=40 -60,6 +63,9 =40=40
> >  =23define PCIE_MSI_INTR0_MASK		0x82C
> >  =23define PCIE_MSI_INTR0_STATUS		0x830
> >
> > +=23define PCIE_PORT_GEN3_RELATED		0x890
> > +=23define PORT_LOGIC_GEN3_EQ_DISABLE	BIT(16)
> > +
> >  =23define PCIE_ATU_VIEWPORT		0x900
> >  =23define PCIE_ATU_REGION_INBOUND		BIT(31)
> >  =23define PCIE_ATU_REGION_OUTBOUND	0
> > =40=40 -244,6 +250,7 =40=40 struct dw_pcie =7B
> >  	struct dw_pcie_ep	ep;
> >  	const struct dw_pcie_ops *ops;
> >  	unsigned int		version;
> > +	unsigned int		dwc_pci_quirk;
>=20
> I'd prefer called this variable just quirk, the prefix is redundant here.
>=20
> >  =7D;
> >
> >  =23define to_dw_pcie_from_pp(port) container_of((port), struct dw_pcie=
,
> > pp)
> > --
> > 2.7.4
>=20
> I understand your idea and I'm fine with it, but I just wonder if there i=
sn't any
> other typical way to do this kind of quirks... I'm not seeing a similar c=
ase to this
> although.

Even we didn't see any existing approach to address this.

> For me makes more sense to squash both patches (1 and 2), since we aim to=
 add
> this quirk especially because it focuses is on this =22GEN3_RELATED=22
> register in a logical patch.
>

Done. Posted =5Bv2=5D where we squashed both the patches.
v2: https://lkml.org/lkml/2019/9/13/171

Thanks for review.
=20
> Regards,
> Gustavo