Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp979622ybe; Fri, 13 Sep 2019 09:14:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqxa4fnTAIOS2yHPj4auvZ6hgBV6HlnNwVN0UNVgjP8f2OGBsU95mVtD6D0adwilihp/7edV X-Received: by 2002:a05:6402:b2d:: with SMTP id bo13mr47724527edb.170.1568391241359; Fri, 13 Sep 2019 09:14:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568391241; cv=none; d=google.com; s=arc-20160816; b=vOGphMOCm9JMbm/flMcZmJZmySI1mwzpafOzM8wORb2CsPNIE2qOGXHyrkavJmigMu AF5KJIRnMQJUmZJ/kLeK/BoVhb0qAtWcpoDSSmg+XOr5mZDtrTBBfybT8CG2ZvSZJHkY lOq/3QkjlQlg/xx3ZDlYz+LAE8wzXqAXUvX2ExEwpb3J2YCpKITd463mAWQEbSFBHWTP qupraKLVzwVxtQlCfOvaBIzwzRTzBwGF5HsoyoS0aqYUe+RjhIBXTU/VZhu3jKj4u0mS Ngn0ikcOdJqNd0snH+GXWMEBDCNj+jxnK5twal/gLm3Dz0sy2uGHq+slpHd+5aczaMKF nlxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=q3Ga10yfzeYwpxzznlPXk6UJIJ2TiV9coxLDW5IjRtQ=; b=yLIQnKsw4wscLMrTgA+jgiZQcSxfbBW3g8VksqMH8LbJwb3jTHEU2T710JaHJXD3vP 6urnPADwxAwW84B3fzkSbMEsfNtY8ZDJAiasy9Jp7tNpLDKASMFaV+r4YqptK0G/MjI2 lxQLjwef5aL492wKKTGYfo8Z8T6a57Gb1SBnz2EBrI7FpuaJ7HtSSJTz01QCzgbD5P3N DPFuemgSgl5B9Qi2PUw5s+fjg6muhJqtWU5Ihk7F8gMhB/+n9xKqFd2X302q7bUMNR4L BxkQLb4IxAXNEMOqtgHkAs8O7lgvfZWl4YXn+WPtQcbkaBuj+YVGePDavBtH/upA6uo5 AxbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=C6+DA8OL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p32si18875165edc.259.2019.09.13.09.13.37; Fri, 13 Sep 2019 09:14:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=C6+DA8OL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389462AbfIMOul (ORCPT + 99 others); Fri, 13 Sep 2019 10:50:41 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40784 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388953AbfIMOuh (ORCPT ); Fri, 13 Sep 2019 10:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=q3Ga10yfzeYwpxzznlPXk6UJIJ2TiV9coxLDW5IjRtQ=; b=C6+DA8OLlRAbM+V6wKgn6PB17 KQ72yJDKteynS6SYGdsx4L+4q0GSUma2xxWwnd2xkMmUs6eyGO8MxP5ynQowZRnVfHbKbQhvzowe5 +uHl3oFrIa/d3SJ+DBeJn7ZMEHiv8uSNem5hqiYAOYuBKn9Y11oF0cXStGRcWPNMQvMmJl05A5Yn5 QJVhzqoKz/PMQrziYhddGHQHIaE+6P/fAPbqhoF9M1dAS/AcgIPpnH26rDJJdjNU/xVHUI1NQ2QT/ ElMQUfEXk/pZOjaRK1f1YU2xNJLxNlBceej6u+MsdWy0WjnnLNJdCtIePIXQ4PQ3p2MxPQSfq01CR yTwS2WLjA==; Received: from 177.96.232.144.dynamic.adsl.gvt.net.br ([177.96.232.144] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8muC-0002Mq-2T; Fri, 13 Sep 2019 14:50:36 +0000 Received: from mchehab by bombadil.infradead.org with local (Exim 4.92.2) (envelope-from ) id 1i8mu9-00042n-Db; Fri, 13 Sep 2019 11:50:33 -0300 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Borislav Petkov , Tony Luck , Qiuxu Zhuo , Robert Richter , James Morse Subject: [PATCH 0/7] Address most issues when building with W=1 Date: Fri, 13 Sep 2019 11:50:25 -0300 Message-Id: X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a recent discussion at KS ML with regards to use W=1 as default. No idea if this will happen or not, but it doesn't hurt cleaning up W=1 warnings from the EDAC subsystem, specially since it helps to cleanup a few things. This patch series addresses most of such warnings. After this series, there will be just two W=1 warnings: 1) i5100 EDAC driver: drivers/edac/i5100_edac.c: In function ‘i5100_read_log’: drivers/edac/i5100_edac.c:487:11: warning: variable ‘ecc_loc’ set but not used [-Wunused-but-set-variable] 487 | unsigned ecc_loc = 0; | ^~~~~~~ The ecc_loc contents is filled from MC data, but it is not used anywere. The i5100 MC is very old: the affected code was added in 2008. It should probably be safe to just drop the corresponding data, but, as it may contain some relevant info, I was a little reticent of doing that. 2) Xgene EDAC driver: drivers/edac/xgene_edac.c: In function ‘xgene_edac_rb_report’: drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but not used [-Wunused-but-set-variable] 1486 | u32 address; | ^~~~~~~ I suspect that the content of the address field should actually be used on at least some of the logs. I may eventually submit patches later to address the above cases, but let's solve first the other cases, as they all sound trivial enough. Mauro Carvalho Chehab (7): EDAC: i5100_edac: get rid of an unused var EDAC: i7300_edac: rename a kernel-doc var description EDAC: i7300_edac: fix a kernel-doc syntax EDAC: i5400_edac: print type at debug message EDAC: i5400_edac: get rid of some unused vars EDAC: sb_edac: get rid of unused vars EDAC: skx_common: get rid of unused type var drivers/edac/i5100_edac.c | 2 -- drivers/edac/i5400_edac.c | 15 +++------------ drivers/edac/i7300_edac.c | 4 ++-- drivers/edac/sb_edac.c | 21 ++++++++------------- drivers/edac/skx_common.c | 5 +---- 5 files changed, 14 insertions(+), 33 deletions(-) -- 2.21.0