Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190912022740.161798-1-yuhsuan@chromium.org> <f2d9e339-ef96-8bb4-7360-422d317a470f@linux.intel.com>
In-Reply-To: <f2d9e339-ef96-8bb4-7360-422d317a470f@linux.intel.com>
From:   Yu-Hsuan Hsu <yuhsuan@chromium.org>
Date:   Sat, 14 Sep 2019 00:01:40 +0800
Message-ID: <CAGvk5PoWOQKYT4T18_xTzz=85k3_W_0hnSS3EJCEk4ukkaSzcw@mail.gmail.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: kbl_rt5663_rt5514_max98927: Add
 dmic format constraint
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Jie Yang <yang.jie@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        Tzung-Bi Shih <tzungbi@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        alsa-devel@alsa-project.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> =E6=96=BC
2019=E5=B9=B49=E6=9C=8812=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=889:0=
2=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On 9/11/19 9:27 PM, Yu-Hsuan Hsu wrote:
> > 24 bits recording from DMIC is not supported for KBL platform because
> > the TDM slot between PCH and codec is 16 bits only. We should add a
> > constraint to remove that unsupported format.
>
> Humm, when you use DMICs they are directly connected to the PCH with a
> standard 1-bit PDM. There is no notion of TDM or slot.
>
> It could very well be that the firmware/topology only support 16 bit (I
> vaguely recall another case where 24 bits was added), but the
> description in the commit message would need to be modified to make the
> reason for this change clearer.

(I sent it again because the previous email contains HTML subpart.
Sorry for the inconvenience.)

Thanks for the review! If I'm not mistaken, the microphone is attached
to external codec(rt5514) instead of PCH on Kabylake platform. So
there should be a TDM between DMICs and PCH. We can see in the
kabylake_ssp0_hw_params function, there are some operations about
setting tdm slot_width to 16 bits. Therefore, I think it only supports
S16_LE format for DMICs. Is it correct?
>
>
>
> >
> > Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
> > ---
> >   sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/soun=
d/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> > index 74dda8784f1a01..67b276a65a8d2d 100644
> > --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> > +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> > @@ -400,6 +400,9 @@ static int kabylake_dmic_startup(struct snd_pcm_sub=
stream *substream)
> >       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNEL=
S,
> >                       dmic_constraints);
> >
> > +     runtime->hw.formats =3D SNDRV_PCM_FMTBIT_S16_LE;
> > +     snd_pcm_hw_constraint_msbits(runtime, 0, 16, 16);
> > +
> >       return snd_pcm_hw_constraint_list(substream->runtime, 0,
> >                       SNDRV_PCM_HW_PARAM_RATE, &constraints_rates);
> >   }
> >
>