Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1122313ybe; Fri, 13 Sep 2019 11:22:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqy44rnTDUq57rYA8cB2jyMWk+2eLIpO+3Y6/ZdMQBkSxqZ/k+ovKraEfLvkE2mka8mSquLs X-Received: by 2002:a50:b6aa:: with SMTP id d39mr12417320ede.16.1568398931342; Fri, 13 Sep 2019 11:22:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568398931; cv=none; d=google.com; s=arc-20160816; b=aO0FVfXVciCTasgGba9q6CBEXRYShBWNdUuq0Z8FNBI3r8hwdfmlhMAUISWstMBy/V /eBOIGcrpu+wSothR0gSZDYrZ3ijvD1bGqIfQoaOH9vRfaFKU7CdUtc5LyF3xZH6bps1 +WJrQuTyjCjTrN+4LW8GcROCC1s1OQQtWqqKRjFNQF8FMTDxOF5/KVUqGzTWgJpkldCm Tx13pv6nWcJ8DhgQ47IBxgxcf6yYwRNTiqwHNPDLJBZpAc8wJ6x5BDq+TvsBymqJKLq+ cHjzR3uCbEdf/bAEvDG1b9M5IGSaHiXMO5UhSe3/g0misG81znob/CIGeZoC3FWP1Ee9 dfKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FYsaMCuusobrrTMlQW9QlaP1hGESU1sHXOFQSMDkgLA=; b=S4etnM0QIaLOVWgaUil28mJrg9KbjMocwcNaMhT80GwU7XpEcTZlHXzMFr4i5GkmM6 fVIbfk5cYdGgIXndpVwNH1YeOefbgaotl8jE4FN8yBeBNwHPYkb64yY6sYXq6qbRhqQg iS16f0uz+wOsv/O/dL4l7dYfNGYWSC1RcDyEx9PZCrgZ3n6Ppiv7TM5HgreAAQ2ZPdxF CREKawZ7wjWGVd0no0Ugt+C8PDOMPts/ZEAVK53XztRn4nzmu7K+twuGVETK5A3pRNRF slBKVGNGUJJ4qfzpIANXIvSwjfEz3Mz7fhp1Mj/vvFuKa09MJRWquTPFTRY2dq5x5zUS Mjew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WDf3l8xo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3si14922279ejk.313.2019.09.13.11.21.47; Fri, 13 Sep 2019 11:22:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WDf3l8xo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389831AbfIMNQS (ORCPT + 99 others); Fri, 13 Sep 2019 09:16:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:42912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389825AbfIMNQQ (ORCPT ); Fri, 13 Sep 2019 09:16:16 -0400 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D0BF20717; Fri, 13 Sep 2019 13:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568380575; bh=A1OEtCB6vF6AkWgRcCleL1BEUoTuRzPNYoc/GZtwK1k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WDf3l8xot3JAKdYXkM0MDwS7Qc06XTJqXtHXcMQY2FoJkPvRyEitR09IQWrG7yqXe 6Qu0vAq7bQU+Nuy/ALwgXZhZK8O+GFE+oaVtxye3PuKL/C7Wozk2RysBOVu9zFyfbo EKG0Kt6xnb7ElhJgv604klNRZfGcVv48c0LWY4iw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felix Fietkau , Sasha Levin Subject: [PATCH 4.19 091/190] mt76: fix corrupted software generated tx CCMP PN Date: Fri, 13 Sep 2019 14:05:46 +0100 Message-Id: <20190913130606.900459859@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190913130559.669563815@linuxfoundation.org> References: <20190913130559.669563815@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 906d2d3f874a54183df5a609fda180adf0462428 ] Since ccmp_pn is u8 *, the second half needs to start at array index 4 instead of 0. Fixes a connection stall after a certain amount of traffic Fixes: 23405236460b9 ("mt76: fix transmission of encrypted management frames") Cc: stable@vger.kernel.org Signed-off-by: Felix Fietkau Signed-off-by: Sasha Levin --- drivers/net/wireless/mediatek/mt76/mt76x2_mac_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_mac_common.c b/drivers/net/wireless/mediatek/mt76/mt76x2_mac_common.c index 6542644bc3259..cec31f0c3017b 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2_mac_common.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2_mac_common.c @@ -402,7 +402,7 @@ void mt76x2_mac_write_txwi(struct mt76x2_dev *dev, struct mt76x2_txwi *txwi, ccmp_pn[6] = pn >> 32; ccmp_pn[7] = pn >> 40; txwi->iv = *((__le32 *)&ccmp_pn[0]); - txwi->eiv = *((__le32 *)&ccmp_pn[1]); + txwi->eiv = *((__le32 *)&ccmp_pn[4]); } spin_lock_bh(&dev->mt76.lock); -- 2.20.1