Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1212711ybe; Fri, 13 Sep 2019 12:51:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqwZcHhfbcunyG5/LKFAcri5TImvSL/SOY51whqBNPRsJUvenpONllizE4pAXOBl0W+F9p/r X-Received: by 2002:a17:906:2288:: with SMTP id p8mr39645777eja.250.1568404272353; Fri, 13 Sep 2019 12:51:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568404272; cv=none; d=google.com; s=arc-20160816; b=h6Yrn8pE/kbc1RsMBN0TFZrNGBN47VNuHNpFBmHFovc3U+44RLjmtsGCRALOoZMR3G BEApc3MoVsMVI7pozWjybSRXqI1fjA/x6ghZkOMb3hIPNktN8PglLZDoCWMz9xsDrnLX 4k02af882nYiYCNnbJY6CIYEKL/0vu+hjaGg1qK6WpjHo+RPnQ5etEJwKCa3Ku3TYNqw +YoaQtNHS8FvVacmT7PRozfNhv+mnfovFtXRYPrHn20LRMT7jpwj6VpkEDs/JVeYkkSM MNu6KSRVnz9ULVJ2BPT3YqK78ntge8PUmCWIHqKOWw4qCCaU6aCukPoUXGD3H5R6GNSm CSwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=b09Rd6phJSXjwJGv3NU6C2d2NqtbEENVTfCKqJOaTF4=; b=e9ZIabBFUixAz9U067nB8NWOzxcXvadRSMr2bOcGOvpAu/cl2pm5XP8n8upId1AzSe rIEToXms2Yv/6GwOPuf63mUXUv+r7P6inSjdjbscHjDW2pUZFL6w5bweavc/WLT9/cTf RN+JAWrQ37XHR4yF2nAsy1kntVqlU0egteBKCqZ2IN2qHJ3J4w9JkDNV5o4J7Mq7MM2R zdGpV6nXphPhbUTbT9e9znEHqNNUtoYuKmJ8qqnAjpMjj63mhf/8h+BEwLI4bupp0Pwm qPmD8nv8Vx5unFNfcqgphe9DCKtNh8ZHFy0XC4vDPVZ4zhSbIwVGJpJfM6dEl9lllU0K Vd3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cb11si15077926ejb.38.2019.09.13.12.50.48; Fri, 13 Sep 2019 12:51:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729670AbfIMS67 (ORCPT + 99 others); Fri, 13 Sep 2019 14:58:59 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:59176 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbfIMS66 (ORCPT ); Fri, 13 Sep 2019 14:58:58 -0400 Received: from turingmachine.home (unknown [IPv6:2804:431:c7f4:5bfc:5711:794d:1c68:5ed3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tonyk) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 0D52728F197; Fri, 13 Sep 2019 19:58:53 +0100 (BST) From: =?UTF-8?q?Andr=C3=A9=20Almeida?= To: linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: corbet@lwn.net, axboe@kernel.dk, kernel@collabora.com, krisman@collabora.com, =?UTF-8?q?Andr=C3=A9=20Almeida?= Subject: [PATCH 0/4] null_blk: fixes around nr_devices and log improvements Date: Fri, 13 Sep 2019 15:57:42 -0300 Message-Id: <20190913185746.337429-1-andrealmeid@collabora.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, This patch series address feedback for a previous patch series sent by me "docs: block: null_blk: enhance document style"[1]. First patch removes a restriction that prevents null_blk to load with (nr_devices == 0). This restriction breaks applications, so it's a bug. I have tested it running the kernel with `null_blk.nr_devices=0`. In the previous series I have changed the type of var nr_devices, but I forgot to change the type at module_param(). The second patch fix that. The third patch uses a cleaver approach to make log messages consistent using pr_fmt and the last one add a note on how to do that at the coding style documentation. Thanks, André [1] https://patchwork.kernel.org/project/linux-block/list/?series=172853 André Almeida (4): null_blk: do not fail the module load with zero devices null_blk: match the type of module parameter null_blk: format pr_* logs with pr_fmt coding-style: add explanation about pr_fmt macro Documentation/process/coding-style.rst | 10 +++++++++- drivers/block/null_blk.h | 4 +++- drivers/block/null_blk_main.c | 24 ++++++++++-------------- drivers/block/null_blk_zoned.c | 6 +++--- 4 files changed, 25 insertions(+), 19 deletions(-) -- 2.23.0