Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1343060ybe; Fri, 13 Sep 2019 15:08:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqyicpTJQCoy7eYgvVK0VpQE2sQqtHQ+8mKxW2wjrD+qt8+wAU6ulC3Zy/ArydWcgrY9cEds X-Received: by 2002:a05:6402:547:: with SMTP id i7mr49802455edx.179.1568412501529; Fri, 13 Sep 2019 15:08:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568412501; cv=none; d=google.com; s=arc-20160816; b=otA5QLRiMro+2dQbxZBw3pkRWhyAdcghc940lzvu6lpkwuNiJyO0lSd6reWE1ZzfEP COxaLpcufXkZuZDY9guY47dnrNaFcKoJ3jq5XfOG8gcSfIafbrhp9uJeG/fF5mte70R8 ApkKw0bxCCCRz/BtQSkwPIaluDjHA1FbfRLRPhyuPLVFm0bTkAcEFQ+LIYV7RpM2mOAY GZg1NMMqHqvMAtTccf7adBcfw1U1xADqAtM5rWFy6jIIxH1ubdadbiOZ9XvcS4z4HipJ SMQz5T469L/sKg88E9VvrGHlfu2AcRpGbEBn1+cVciz726xsimbmYKJb8E9bM1qQBjRk Hr2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=GpLuSv49/2eTWC8xLdvYbI9k5TquU1ypa30ZoVR7els=; b=YdLdghTqHpHugs/p1iYZ5958S7WMXfynyV9qBGdYqLJ58YYMWb+FacoJsv0e9PLy/e j9BZHwINOFzYC5hm0SyYI4oQ9aaadbvMPl1V10bmAZHW8Qau4IXeiHTX96ZqqwsXHz56 OJmaKLeYO9ZRLeN3Eq8KyL2EztnyTGu0lMnEIfrb1KAcJOLk14OZ3W+012BTS4lgKmdF g4Ee/LuNkO09eMBh1CR9x8UlRIxb7KGHMc0Bpy/GQY8g+WkOmQB6At3BwHWo40ZY4J3R mnw/9RuP7oMoItH0Jx6JxdCLy+Ac4yCvyS1n+kd/c5TkvydI+9VWAJpxZqSMynnIi0OR UQtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p32si19451431edc.259.2019.09.13.15.07.58; Fri, 13 Sep 2019 15:08:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403862AbfIMWEN (ORCPT + 99 others); Fri, 13 Sep 2019 18:04:13 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:60786 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387554AbfIMWEN (ORCPT ); Fri, 13 Sep 2019 18:04:13 -0400 Received: from turingmachine.home (unknown [IPv6:2804:431:c7f4:5bfc:5711:794d:1c68:5ed3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tonyk) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id A754228EF34; Fri, 13 Sep 2019 23:04:08 +0100 (BST) From: =?UTF-8?q?Andr=C3=A9=20Almeida?= To: linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: corbet@lwn.net, axboe@kernel.dk, kernel@collabora.com, krisman@collabora.com, =?UTF-8?q?Andr=C3=A9=20Almeida?= Subject: [PATCH v2 0/4] null_blk: fixes around nr_devices and log improvements Date: Fri, 13 Sep 2019 19:02:56 -0300 Message-Id: <20190913220300.422869-1-andrealmeid@collabora.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, This patch series address feedback for a previous patch series sent by me "docs: block: null_blk: enhance document style"[1]. First patch removes a restriction that prevents null_blk to load with (nr_devices == 0). This restriction breaks applications, so it's a bug. I have tested it running the kernel with `null_blk.nr_devices=0`. In the previous series I have changed the type of var nr_devices, but I forgot to change the type at module_param(). The second patch fix that. The third patch uses a cleaver approach to make log messages consistent using pr_fmt and the last one add a note on how to do that at the coding style documentation. Thanks, André Changes since v1: - Add "Fixes" tag at [2/4] - No more headers reordering at [3/4] - Use #undef pr_fmt and KBUILD_MODNAME at [3/4] and [4/4] - Replace "printk.h" for "kernel.h" at [4/4] More details are provided at each patch changelog [1] https://patchwork.kernel.org/project/linux-block/list/?series=172853 André Almeida (4): null_blk: do not fail the module load with zero devices null_blk: match the type of parameter nr_devices null_blk: format pr_* logs with pr_fmt coding-style: add explanation about pr_fmt macro Documentation/process/coding-style.rst | 10 +++++++++- drivers/block/null_blk.h | 4 +++- drivers/block/null_blk_main.c | 24 ++++++++++-------------- drivers/block/null_blk_zoned.c | 6 +++--- 4 files changed, 25 insertions(+), 19 deletions(-) -- 2.23.0