Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1376094ybe;
        Fri, 13 Sep 2019 15:50:02 -0700 (PDT)
X-Google-Smtp-Source: APXvYqzEEiIi0lEe+J8cPuK5aRvC/PrxzTb32Y6l59+n9TOP2AxNzQ0IafVUSTBXlXNpQ7WX5Gs0
X-Received: by 2002:aa7:c1c5:: with SMTP id d5mr49860592edp.46.1568415002811;
        Fri, 13 Sep 2019 15:50:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1568415002; cv=none;
        d=google.com; s=arc-20160816;
        b=kstbEqPI8sgsl+y/hWX2ca8CDGRr1yOrBnPV2pahLCs3ER+pR7aZsUbOx9hSK51Lgz
         GTPtYGCPyBJjIeTK8sKkVJKgUTEtuOhCCVn9SvCOtDAtMrFVpOlutT8eXtK2FuamnFEY
         lLaKo6PSYRyxPVNAHNnyfB+jRbLqqLKSdakLfYbbS3p2BN2Bflmbdk0cXRlgUEQxW3xM
         /+Nqnn+3xKBurroFNS4ORnOHZlmE+qaQdMs4xrwxdQ2yi3wLqD6G61FKODvIcnWYMHAH
         nKQdryekqaQdLXpnO6r1pjsngWPUC8OhpE9TsqRhx0qfMH5rzLTQK+ATH9A1Edu9LIKe
         5kQQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=8/PTuAQNJHqIvg2MM/HG3ygInLUH8FO9HvUCmgN7iCg=;
        b=L5hY3OuzinCOaeevjr7ue/O1VTS1+AbQk5z/ESmimMAGPxa8Onjs6fslXu2O+J6sLg
         wt5omZdkvYBeN0mV8kqAfPf4c/cp8Oc6FiJKISoiyEiI1ERXuALz9bkbqm484GLyI5DS
         HQWmuV2klAFInrUcUrydehTPkIbl3I+jDD5vQ5YMUtITVOea+SKlR/lyr3F6Ce/ULmvi
         J0qROosuAJbTN8tXc4BhntoM709b3J0ELrnIdTtehmeQq+qczScRn5IYOOhrAbxg2kBI
         JOgvDREsBJ1M9WbnlBKBTED1Xe1z1W4idoCx4H9cE8/Faz1nVZ84JVnOrjgK7nOezbgN
         w4SA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=Yyh5Z7sJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id g10si15317615ejk.250.2019.09.13.15.49.38;
        Fri, 13 Sep 2019 15:50:02 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=Yyh5Z7sJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2404176AbfIMWpf (ORCPT <rfc822;gklkml16@gmail.com> + 99 others);
        Fri, 13 Sep 2019 18:45:35 -0400
Received: from mail.kernel.org ([198.145.29.99]:54182 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2404024AbfIMWpe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Sep 2019 18:45:34 -0400
Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48])
        (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id D750C214DE
        for <linux-kernel@vger.kernel.org>; Fri, 13 Sep 2019 22:45:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1568414734;
        bh=8/PTuAQNJHqIvg2MM/HG3ygInLUH8FO9HvUCmgN7iCg=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=Yyh5Z7sJFO6Dy8bjoesC7bphmvs9X4qf/Rp25qGuTBMNO8kbhu5iCTBQR/5N5qP1p
         v5hxQ62v96pZKpTlkyPE7izGs1OZwm6wscNeIDC31s7QhD7fKHAOaoIfN6TlEXT1Fd
         TUhGUG1U4Nx0UH8+AtwS8CdoJmwnJzjBLpyb4GJY=
Received: by mail-wm1-f48.google.com with SMTP id q18so4236015wmq.3
        for <linux-kernel@vger.kernel.org>; Fri, 13 Sep 2019 15:45:33 -0700 (PDT)
X-Gm-Message-State: APjAAAUvcyDlVtd7uzetKjhnpr5zK59JAWDlGmvD6P87AeDxyX445KRy
        fN4CYqv5WCOc/ldoQDR8jz92vMmp9lvVPY8TtQtz4A==
X-Received: by 2002:a05:600c:285:: with SMTP id 5mr5514402wmk.161.1568414732419;
 Fri, 13 Sep 2019 15:45:32 -0700 (PDT)
MIME-Version: 1.0
References: <20190913210018.125266-1-samitolvanen@google.com> <20190913210018.125266-4-samitolvanen@google.com>
In-Reply-To: <20190913210018.125266-4-samitolvanen@google.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Fri, 13 Sep 2019 15:45:21 -0700
X-Gmail-Original-Message-ID: <CALCETrWquNJJ6yXdHA_F3h71hVrFjnpwmdH2NmGZyFu-V6Lnfg@mail.gmail.com>
Message-ID: <CALCETrWquNJJ6yXdHA_F3h71hVrFjnpwmdH2NmGZyFu-V6Lnfg@mail.gmail.com>
Subject: Re: [PATCH 3/4] x86: use the correct function type for sys_ni_syscall
To:     Sami Tolvanen <samitolvanen@google.com>
Cc:     Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 13, 2019 at 2:00 PM Sami Tolvanen <samitolvanen@google.com> wrote:
>
> Use the correct function type for sys_ni_syscall in system
> call tables to fix indirect call mismatches with Control-Flow
> Integrity (CFI) checking.

Should this be SYSCALL_DEFINE0?