Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1721711ybe; Fri, 13 Sep 2019 23:59:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFQZxmHrMYMd09EGfF8KgwBCMe0edQyY2Bbu++EZ48cgZHAaq2gEHVP78RhZys0uIpono5 X-Received: by 2002:a17:906:fae2:: with SMTP id lu34mr1079832ejb.53.1568444373172; Fri, 13 Sep 2019 23:59:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568444373; cv=none; d=google.com; s=arc-20160816; b=WLokyQ9JvB9VjBAjcx74HulS+56XY6qy/4THjrvMwkjYbQfeRTGSaxo53NWnLib5tl Y+x00/4QckjwAYmGT9ijaJo3KhEutdvUVt9JDZcNCl2dwsa/bOS8Y1DiKmxUmtjFq2uE TWQgD6T66BqPmuPtyN1PiAIVKvaDEl+BvsHXNklWMRyXRtHNnzvy4uELPNhllcBt73oW 5mzFU5SQxzIFhHcwX3Tia6jgirnafd3Jb+fNWoi3aa5AHlJ2leKc3Iny+qT40SBLARdT ulFOfDDYc1T65gNXwjaxnu87nGqC1FCFp2Ec3sUOGsMA+N2E4eHtZ1r6Hq2tq0aloYdf WU/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=hnvJQe+C3TnSHto3c1xZFGfpsYLnfxYwwNuByHRB6Ck=; b=PCCZPd+m1KmGBkoTPPSadZmDQdodv38Wl817svDVT5Z06W1K2V6M1KNxdDSCbblT6W lSQTHdg9JEnn9Hx4jwJaBMdQusX7dlGkUeW61I2u+cwDjlKVWhoBzFTThtM9vefLnakh prUBZ2kfQeKJXIHk7ZgXSOM6Hz6uKwuXew64wy/7HB7+SVqLHssmQOi84mw7Y7pFRume HC0qEaqYfsYk/wpvwFBq0s+vWCQ6ABLZxmMjEPEyFW4kaamO8SCX7ayB124nbXqqsrbF ZgqnYBvtG58Mcu0lIA1Gqr35T+EWY8E605CJmyXpeL7/kcX83X6vNOIDKZCroGrrxkLU f6XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si19077746edc.231.2019.09.13.23.59.09; Fri, 13 Sep 2019 23:59:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730442AbfIMTXh (ORCPT + 99 others); Fri, 13 Sep 2019 15:23:37 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:59418 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbfIMTXg (ORCPT ); Fri, 13 Sep 2019 15:23:36 -0400 Received: from [IPv6:2804:431:c7f4:5bfc:5711:794d:1c68:5ed3] (unknown [IPv6:2804:431:c7f4:5bfc:5711:794d:1c68:5ed3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tonyk) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9D41128BD60; Fri, 13 Sep 2019 20:23:32 +0100 (BST) Subject: Re: [PATCH 0/4] null_blk: fixes around nr_devices and log improvements To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, corbet@lwn.net, kernel@collabora.com, krisman@collabora.com References: <20190913185746.337429-1-andrealmeid@collabora.com> From: =?UTF-8?Q?Andr=c3=a9_Almeida?= Message-ID: <467709ad-e174-4d4a-6906-aba5bf7a8111@collabora.com> Date: Fri, 13 Sep 2019 16:22:26 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/13/19 4:03 PM, Jens Axboe wrote: > On Sep 13, 2019, at 11:58 AM, André Almeida wrote: >> >> Hello, >> >> This patch series address feedback for a previous patch series sent by >> me "docs: block: null_blk: enhance document style"[1]. >> >> First patch removes a restriction that prevents null_blk to load with >> (nr_devices == 0). This restriction breaks applications, so it's a bug. I >> have tested it running the kernel with `null_blk.nr_devices=0`. >> >> In the previous series I have changed the type of var nr_devices, but I >> forgot to change the type at module_param(). The second patch fix that. >> >> The third patch uses a cleaver approach to make log messages consistent >> using pr_fmt and the last one add a note on how to do that at the >> coding style documentation. > > Please add Fixes tags to your patches. > I've added to [PATCH 1/4], should I add to all 4 patches?