Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1862576ybe; Sat, 14 Sep 2019 03:15:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyxkxP4Ksks8fC/C5YSyZXf13hP7PSTpJrUqiT89tS4sxCKfRKj3GIE4wmHz/6CEJb+JVxb X-Received: by 2002:a17:906:308a:: with SMTP id 10mr39799267ejv.277.1568456150052; Sat, 14 Sep 2019 03:15:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568456150; cv=none; d=google.com; s=arc-20160816; b=J9G86MFO0eoaIj5+CVpIrn0kR9dczY9Hzje+f10MZZwA43ClasqOP5HN+RjqBgrh6n 0v7YurS8oX+SIKaseZ9sYrLryAbXKuheADiDmmip4CPlZpmgAlTUr3Ve5NkwLm1fWqKl T9zCwEK59JHiZbGNcIvd4xcom2oL7DSNPc17BzmnuL7Jehxo/jPG3CEBWZPYR/4FZaiP tszmD98fZK1xDLbtHZNVxqkGw1Z6O1crYWOe54gl9ugMO478bedgwUYbWLEFbhgq2oZC /1tmmTc9eFcwCTsm+cOkp4DN+9Mof27ADyyFYuf9GYg6rgUuqfP/q631/asr1ZfZNcjV qhMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=2DisDR/cJhM64R78LUA1TAvaEYUe5ftHQT+Ynd0imlo=; b=NMhR2p8ofsfBETFYN55fmueue4GeWTmEqKmtOTBQGKKyPquWEGbAkCzNR+fcYJzol3 xEEyQGeKXURzR98Tt97zgEXWmNlOB4PXK4M31qvyh8wIr4v16Jc3yJVnqdIMd73sw80o SrU71rIVEgcoKamJ6MFJFxsetJWEZkCHpU6DvqlybaclsYyLeU5UIvvV+iyBAYpf/5HP UNNbFu4h/zVwarbTOjynfSMAAc0JacUZAsZOTKSZIRxBuZwjPrl8qB0DxHC5oL/dyTDF BEqxJYyQVfIjLS6veYp3zQf9AjDTLR3TUj86SCV5x+kqaBFosVUDFSx7bXCkJnl5wFWO ONwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BWwJ61Tx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q28si17271488eda.322.2019.09.14.03.15.03; Sat, 14 Sep 2019 03:15:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BWwJ61Tx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731198AbfIMVFN (ORCPT + 99 others); Fri, 13 Sep 2019 17:05:13 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:37263 "EHLO mail-wm1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbfIMVFN (ORCPT ); Fri, 13 Sep 2019 17:05:13 -0400 Received: by mail-wm1-f48.google.com with SMTP id r195so4145102wme.2; Fri, 13 Sep 2019 14:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2DisDR/cJhM64R78LUA1TAvaEYUe5ftHQT+Ynd0imlo=; b=BWwJ61TxX2jZxRKjKsHdxAuRqSXMAKi+BP5djX6lCCI4CTx3viCbHzwg7gvLT9gg+V zoP8AL7WvxuKN0W/7l+VlyNCMWUC2d9K+3Od3V/XUmnC8d6+7J7XbQx/WS9UWTtcxfoR ozVGPUT1esSZiJWobCSapv6x38//BorJXk0qkg7WCowdeblf3Kvs+1SzodHmSKhcVbkY 3LdUtdOSmqUt4TOLtB/qEPhM9Kx+LL6MsXBD0TE1Xcv2iJeVIMwRbDQRPvdCyi0hx5gN ysXTZQYaqCUR+pkU1z20wkCWmMxbH5CMTrtKhPyZOSqdAcDxdu082jLHAj5dAlJbv7P4 4HbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2DisDR/cJhM64R78LUA1TAvaEYUe5ftHQT+Ynd0imlo=; b=Y4oEStd/3Bx6G9cuhaYEW659x+8JU0qkxn21pKlaU7QfIY8opNvSpqSEGJuMF4b4xa owgLk3aQHVG9YtR+95S0q8BNC4hojkBYFvViYFxDcASAUL18JlAUmUVCwaXADYb3f3wh lwkVCZqKxEMLRUQvGZ+TcOcSZ6cdhyyhIHubrLA5fat36ejw980WWWTeqOmh/ZaTG/VI R3DyfcZ09it52ur5h2NzEvi0N5OL13zDNtHqIHLJUod3Au46hnXzrB4H6JVXUl92DEHW O9Atr+dxLs0bUFqfKMtSzCluHoYtLf/czZZroczwmUmJEXDzexxKLlg6H1AemNJgqKV8 vcgg== X-Gm-Message-State: APjAAAVpeuS3WE3hjNa16US41qmJGW+zDDvbk5lYRrznG100GGd8c/H7 2YQPG24L7M8xFRHa2b8hwjVQ/XRgv8GtU4fGZeM= X-Received: by 2002:a05:600c:2308:: with SMTP id 8mr5184148wmo.67.1568408711053; Fri, 13 Sep 2019 14:05:11 -0700 (PDT) MIME-Version: 1.0 References: <1567491305-18320-1-git-send-email-zhongjiang@huawei.com> <62b33279-9ca9-5970-5336-a8511ce54197@web.de> <5D70A196.3020106@huawei.com> <5D70CB7A.8040307@huawei.com> In-Reply-To: <5D70CB7A.8040307@huawei.com> From: Alex Deucher Date: Fri, 13 Sep 2019 17:04:59 -0400 Message-ID: Subject: Re: drm/amdgpu: remove the redundant null check To: zhong jiang Cc: Markus Elfring , kernel-janitors@vger.kernel.org, Maling list - DRI developers , amd-gfx list , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 6, 2019 at 3:01 AM zhong jiang wrote: > > On 2019/9/5 16:38, Markus Elfring wrote: > >>> Were any source code analysis tools involved for finding > >>> these update candidates? > >> With the help of Coccinelle. You can find out some example in scripts/= coccinelle/. > > Thanks for such background information. > > Was the script =E2=80=9Cifnullfree.cocci=E2=80=9D applied here? > Yep > > Will it be helpful to add attribution for such tools > > to any more descriptions in your patches? > Sometimes, I will add the description in my patches. Not always. Applied with some minor tweaks to the commit message. Thanks! Alex > > Thanks, > zhong jiang > > Regards, > > Markus > > > > . > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel