Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp1979934ybe; Sat, 14 Sep 2019 05:39:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqw6VRHwccuan2guDkRgvd3r0BnDfQP2JSMWHnJ3kpb6Pmcf6ouLDGMPcEWXo90iW7e/FsEQ X-Received: by 2002:a17:906:1197:: with SMTP id n23mr44669542eja.122.1568464796258; Sat, 14 Sep 2019 05:39:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568464796; cv=none; d=google.com; s=arc-20160816; b=S8RhYDRoX7bultk7bdb4r+IaMaZhnxNOGzGC3RfuQRbh7AqjQ/IhOKcgLnOvmb3UAa 8SKnnzRFxBz2wAiXmwkU4LQ69N8kGoA8hXVxnSL9JLGZ+++HKOJhB3XdcmwBqpUaqn1c qj/a9FsaScGwbahFGVKLndqtQ1Q4WZqsDdYG6stOPoakBce7XWI+ft35nf/PP9LoSNp8 +pDTEXpOpcUmi3EXxOrmF/WVVKRq+zq6OZAjraWiY5gYHxKGmI1NAZOkZg+tW8IQJ+Sp 5srjcA/Wst+dQe/7LFPdV1pp8kCkkhAiQqqeZKIEiEof7jU6K5vGI5FeI5uF6ulR9BJl /ikw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5OuUUYePxpHluCqMl7cvfllWii8PgjzTxgE9+4rxXRM=; b=sSjJsQvlP52ThxmAVNSg4QC4T+3QJpz1JmA9KPzSi9jmOQmBKVR9EnGyx47lR5F3Zg I1VhxoM5tPcclM0XutRg+XUdmwsJhLnaV2ecvlCxzEyA2YQvLck0StZHWjqnBf7ubwNG EZ684SkMi7gp1+rQS6xHYzoBCBdcV3q/O9QBCdeWDIbDdFU6rrKMhzPQX8UeObM4jrN0 zhGpfEslFXv3OtkFnpU6j3lTCRYoDvxvp1+MoEMW2mXjBIaZhB1v6kSV7ZG/2c5gLoBr Wltd/vVCEqkqQUrDARFsyL1YgxmrT6vBzhW3IHU2fttgeYX+ke6rG4LVXEKcAg4k6SPe n8yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZKFaxzvW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y3si1625189ede.38.2019.09.14.05.39.33; Sat, 14 Sep 2019 05:39:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZKFaxzvW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390314AbfIMWDX (ORCPT + 99 others); Fri, 13 Sep 2019 18:03:23 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:41877 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389617AbfIMWDX (ORCPT ); Fri, 13 Sep 2019 18:03:23 -0400 Received: by mail-pf1-f193.google.com with SMTP id b13so18900235pfo.8 for ; Fri, 13 Sep 2019 15:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5OuUUYePxpHluCqMl7cvfllWii8PgjzTxgE9+4rxXRM=; b=ZKFaxzvWbhRmu4uN/9qxncrxzMsoDyXA3zns7wrGS75pXmzy0AKIHEhTb5ikpfucyR c3XuA4tHbMivSmlOavtBIf/v8rQxgAgkdlQXPCd4heteRYJHEATd/4UlHvGJTngZjT87 mZw6Po9kl50Ad/koB+J1mrjckoQCmoJ/0yadY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5OuUUYePxpHluCqMl7cvfllWii8PgjzTxgE9+4rxXRM=; b=OS/rjJiTuy3oFEtjQdc/aB16q8//yo1lXXVMNdpyN6CWa7x8khszClVblJhEY2nvsK KK/sAup6caIB11P7CQMtSRwM8Wj0MVAG14m8e+Bw6EpChfbH4fQU3JngmK0yQ9j9me9O u/uOtG8xKR89JXKAY5wm9AZk+TC4XBfAhGdEwM3ZyflLuCCB+rIoQKG4EpKsXegtTqiu NQBIH5kO9r6MSGcqOZ5YHwxNEPKfzofC3+sWRdJot/Bh2bmXkC/YqyNZstjBHRbxbCrj g4IZZQp8Or64NAQKIJHpRL8XLB00K46GpCqgPyZi+34gBkWa0a+h+XtPRMk0nZbdLweC AVjA== X-Gm-Message-State: APjAAAW35TLD+gXl66Z9kUms98olANPNYRFel4SZ+gXdjig9KWe/8ivv Q0eIThs+8QyJcNF7I8SDHqi7Rw== X-Received: by 2002:a63:29c7:: with SMTP id p190mr9445210pgp.124.1568412202462; Fri, 13 Sep 2019 15:03:22 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id o19sm2524486pjr.23.2019.09.13.15.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2019 15:03:21 -0700 (PDT) From: Dmitry Torokhov To: Jiri Kosina , Benjamin Tissoires Cc: Nicolas Boichat , Benson Leung , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] HID: google: whiskers: signal tablet mode switch on disconnect Date: Fri, 13 Sep 2019 15:03:16 -0700 Message-Id: <20190913220317.58289-2-dtor@chromium.org> X-Mailer: git-send-email 2.23.0.237.gc6a4ce50a0-goog In-Reply-To: <20190913220317.58289-1-dtor@chromium.org> References: <20190913220317.58289-1-dtor@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, the tablet mode switch that takes two signals as its input: base attached switch from the EC and some GMR signal from whiskers when it's folded over. This tablet mode switch is then sent to Chrome, which changes the UI. However, there are some units which have a lot of leakage on the ADC pins that the EC uses to determine whether or not a base is attached. This can result in the base being physically detached, but the EC thinking that it's still attached. The user would then be stuck in laptop mode and wouldn't be able to rotate their display. To work around this let's send "tablet mode" signal when we remove HID interface, which normally happens when we physically disconnect whiskers. Signed-off-by: Dmitry Torokhov --- drivers/hid/hid-google-hammer.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c index 4f64f93ddfcb..3dc6116c8f76 100644 --- a/drivers/hid/hid-google-hammer.c +++ b/drivers/hid/hid-google-hammer.c @@ -498,11 +498,33 @@ static int hammer_probe(struct hid_device *hdev, static void hammer_remove(struct hid_device *hdev) { + unsigned long flags; + if (hdev->product == USB_DEVICE_ID_GOOGLE_WHISKERS && - hammer_is_keyboard_interface(hdev)) + hammer_is_keyboard_interface(hdev)) { hid_hw_close(hdev); + /* + * If we are disconnecting then most likely Whiskers is + * being removed. Even if it is not removed, without proper + * keyboard we should not stay in clamshell mode. + * + * The reason for doing it here and not waiting for signal + * from EC, is that on some devices there are high leakage + * on Whiskers pins and we do not detect disconnect reliably, + * resulting in devices being stuck in clamshell mode. + */ + spin_lock_irqsave(&cbas_ec_lock, flags); + if (cbas_ec.input && cbas_ec.base_present) { + input_report_switch(cbas_ec.input, SW_TABLET_MODE, 1); + input_sync(cbas_ec.input); + } + cbas_ec.base_present = false; + spin_unlock_irqrestore(&cbas_ec_lock, flags); + } + hammer_unregister_leds(hdev); + hid_hw_stop(hdev); } -- 2.23.0.237.gc6a4ce50a0-goog