Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: PbKKCCcmf6/qyF60FLsFB6VRMRC1asIZMb9sDLq+39T0za5GCj+PxYFHzVBD/rZfIwPjJ49ugw
 1S0pFfI0AsrKRBfxDH9tbR436pkFOefemnx0wRqPDiR1U8nNNcrVifd8OIkNxDtUKROaBYi+mQ
 1qx0WlJRx4sel/RKoZycv/AhMxor3dqUAdtJpYuuuztwXs1UlEKvULDnq4L+WBasvt7mEYydkO
 hY0DprjulSjyjA2hF6UwtlDxJ18RtnDBmhGl8wgA4RLXIp8vEREyjmS8cL99dt7zHKmNkKblhr
 Baw=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     =?iso-8859-1?Q?Andr=E9_Almeida?= <andrealmeid@collabora.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "corbet@lwn.net" <corbet@lwn.net>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "kernel@collabora.com" <kernel@collabora.com>,
        "krisman@collabora.com" <krisman@collabora.com>
Subject: Re: [PATCH v2 2/4] null_blk: match the type of parameter nr_devices
Thread-Topic: [PATCH v2 2/4] null_blk: match the type of parameter nr_devices
Thread-Index: AQHVan853E0yY09HDkewz3OnzXieiw==
Date:   Fri, 13 Sep 2019 22:15:26 +0000
Message-ID: <BYAPR04MB5749FDD5229E814F543E51AF86B30@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20190913220300.422869-1-andrealmeid@collabora.com>
 <20190913220300.422869-3-andrealmeid@collabora.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a787632c-171d-49de-47ad-08d73897e121
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2019 22:15:26.3097
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9XWtFtBYmb183iewONlF/EbGC8MH/Ac27XN/YbcCCxtzw/i8C0awsTev8WMhbH8X5dM7wLJu69wiSbWb3eAJ4/yhUOyWVbVzH/NypDf6ETU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4294
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
On 09/13/2019 03:04 PM, Andr=E9 Almeida wrote:=0A=
> Since the variable nr_devices is an unsigned int, the module_param()=0A=
> should also use this type. Change the type so they can match.=0A=
>=0A=
> Signed-off-by: Andr=E9 Almeida <andrealmeid@collabora.com>=0A=
> Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")=0A=
> ---=0A=
> Changes since v1:=0A=
> - Add "Fixes" tag=0A=
> ---=0A=
>   drivers/block/null_blk_main.c | 2 +-=0A=
>   1 file changed, 1 insertion(+), 1 deletion(-)=0A=
>=0A=
> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.=
c=0A=
> index be32cb5ed339..5d20d65041bd 100644=0A=
> --- a/drivers/block/null_blk_main.c=0A=
> +++ b/drivers/block/null_blk_main.c=0A=
> @@ -142,7 +142,7 @@ module_param_named(bs, g_bs, int, 0444);=0A=
>   MODULE_PARM_DESC(bs, "Block size (in bytes)");=0A=
>=0A=
>   static unsigned int nr_devices =3D 1;=0A=
> -module_param(nr_devices, int, 0444);=0A=
> +module_param(nr_devices, uint, 0444);=0A=
>   MODULE_PARM_DESC(nr_devices, "Number of devices to register");=0A=
>=0A=
>   static bool g_blocking;=0A=
>=0A=
=0A=