Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 14 Sep 2019 00:03:26 +0000
From:   Wei Yang <richard.weiyang@gmail.com>
To:     Wei Yang <richardw.yang@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        willy@infradead.org, will@kernel.org, peterz@infradead.org
Subject: Re: [PATCH] mm: remove redundant assignment of entry
Message-ID: <20190914000326.h4ruqmyvo3yisf52@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20190708082740.21111-1-richardw.yang@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190708082740.21111-1-richardw.yang@linux.intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 08, 2019 at 04:27:40PM +0800, Wei Yang wrote:
>Since ptent will not be changed after previous assignment of entry, it
>is not necessary to do the assignment again.
>

Sounds this one is lost in the time line :-)

>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>---
> mm/memory.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/mm/memory.c b/mm/memory.c
>index ddf20bd0c317..d108bb979a08 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -1127,7 +1127,6 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> 		if (unlikely(details))
> 			continue;
> 
>-		entry = pte_to_swp_entry(ptent);
> 		if (!non_swap_entry(entry))
> 			rss[MM_SWAPENTS]--;
> 		else if (is_migration_entry(entry)) {
>-- 
>2.17.1

-- 
Wei Yang
Help you, Help me