Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 14 Sep 2019 07:08:58 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@01.org, Jani Nikula <jani.nikula@intel.com>
Cc:     kbuild-all@01.org, linux-kernel@vger.kernel.org,
        Chris Wilson <chris@chris-wilson.co.uk>
Subject: drivers/gpu/drm/i915/display/intel_display.c:3934 skl_plane_stride()
 error: testing array offset 'color_plane' after use.
Message-ID: <20190914040858.GT20699@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a7f89616b7376495424f682b6086e0c391a89a1d
commit: df0566a641f959108c152be748a0a58794280e0e drm/i915: move modesetting core code under display/
date:   3 months ago

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:3934 skl_plane_stride() error: testing array offset 'color_plane' after use.
drivers/gpu/drm/i915/display/intel_display.c:16328 intel_sanitize_encoder() error: we previously assumed 'crtc' could be null (see line 16318)

git remote add linus https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout df0566a641f959108c152be748a0a58794280e0e
vim +/color_plane +3934 drivers/gpu/drm/i915/display/intel_display.c

b3cf5c06ca5001 drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2018-09-25  3926  
df79cf44191029 drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2018-09-11  3927  u32 skl_plane_stride(const struct intel_plane_state *plane_state,
5d2a19507cb665 drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2018-09-07  3928  		     int color_plane)
d21967740f4b7d drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2016-01-28  3929  {
df79cf44191029 drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2018-09-11  3930  	const struct drm_framebuffer *fb = plane_state->base.fb;
df79cf44191029 drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2018-09-11  3931  	unsigned int rotation = plane_state->base.rotation;
5d2a19507cb665 drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2018-09-07  3932  	u32 stride = plane_state->color_plane[color_plane].stride;
                                                                                                                              ^^^^^^^^^^^
Out of bounds read?

1b500535c513ac drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2017-03-07  3933  
5d2a19507cb665 drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2018-09-07 @3934  	if (color_plane >= fb->format->num_planes)
                                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Tested too late.

1b500535c513ac drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2017-03-07  3935  		return 0;
1b500535c513ac drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2017-03-07  3936  
b3cf5c06ca5001 drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2018-09-25  3937  	return stride / skl_plane_stride_mult(fb, color_plane, rotation);
d21967740f4b7d drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2016-01-28  3938  }
d21967740f4b7d drivers/gpu/drm/i915/intel_display.c Ville Syrj?l? 2016-01-28  3939  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation