Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2489255ybe; Sat, 14 Sep 2019 16:27:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwThLom/Jh31/J9TMPKjlhnYxuZG3FElRQ9Y/QWT5jQeEGTpSbtgfORkQagBko5ZmZFnuAD X-Received: by 2002:a17:906:6048:: with SMTP id p8mr3376036ejj.297.1568503638643; Sat, 14 Sep 2019 16:27:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568503638; cv=none; d=google.com; s=arc-20160816; b=oMPcvc6EsYMaZj5zgarZZnGmsomvksxQW/Npmr1tqK+5z1Vt/3sEM0M7PNYrvyWaeA fqQayMqcZbNyJ2w5xpLp4A7/saS1pkiOitGWFKNqiZV6jvfkER277/hZuWmditgK0Eua 66mxfLqH602HnQF75m/B8+UNpNNAlRP2a3lgDnyQlkc/MGJ4OrZZKXy9wpcf+SW4b/HP OLvEEj9c1Y2luTl+xVW4wIDM+twK+LxkilKusHqiF1xgh6TIEnaV6GR9VZEPH6ZR0BT5 t3XYT8baUpIqfLuuYpjt4gduqT6P+L0LP9S1/EpbMdi3zRg+XSU0nHnvaG+7SR/50Wcz dT1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=O8OpIv/h9Xoj81JoOw7IpoqYu7lWdSRFtiFxO69rTAM=; b=mGVumOn2hIQApe4SESPqUmU2bS14xNcBrUM/T66cRAbbKrImm5T9WyYyUX3GLLSw5e gNVQw/VnkO2YkXK/3f7VKw8ZdF4n+gEVNipE1HLY9eIT4A1WCMDaPgswvKi2bXkhDfTw 7VItwjEaM1ijs5Zy/QxE3bho4TTrMaeKZ0wMYP4IUzVGTgSaJ4j/iK5MFHm6G7n2KUTW I7XY3vUy0jMOYr+Ka5xvfO664e+bAUL87c2/9IXhsFZcxrNahgfNqY/6snbxxfuKx8gf WASUm+vaqvwb6J1PJCtgxTAzYlsuuetR1nTcHmrIeNUzHLXXYnwMYJ/QrF8ZZITy9XGB IHVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0+bxTToa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n3si16818550ejd.71.2019.09.14.16.26.55; Sat, 14 Sep 2019 16:27:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0+bxTToa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730987AbfINRcx (ORCPT + 99 others); Sat, 14 Sep 2019 13:32:53 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:36762 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726628AbfINRcx (ORCPT ); Sat, 14 Sep 2019 13:32:53 -0400 Received: by mail-pg1-f193.google.com with SMTP id m29so690192pgc.3 for ; Sat, 14 Sep 2019 10:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=O8OpIv/h9Xoj81JoOw7IpoqYu7lWdSRFtiFxO69rTAM=; b=0+bxTToacLejfNCVGMh6jt8FMYCKv1JjLTMESP6mI6B/UH3COowPwnU0ICpZb1ukWk 4vZ1TxRfpmGAO3GBmiop27eE9B8cU/0shzMBpyQ9ttFvnEYWSxBaQmrB9Y8hbtKpEtDf rHaz5HewXCaXyFFyqeh07pZlphnDMay+V3U29gfv4c0cBAeJiZ5ljvaG3TNV9JahHo5F ZsSRriNWhgc9CKeOmFcp76uCZ/bWD5IWwi9l04F9m60NnIENgIIkpsquNpOg/2DvF2QU +hk2ZOjmgM+p93hqSdqnE11DCP66QlQqoQFpGTaxi9AZvQbE2dmhPwOvV/Z1CuSpzIUN Ad8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O8OpIv/h9Xoj81JoOw7IpoqYu7lWdSRFtiFxO69rTAM=; b=gRZGYO7lsoaTWyR4dD9GCOJVgkh4IwINEVpBCPQoYiKpagF/fkmMfJ8KXVrrBvYFTU PEgqdorgYCMWyGiehhuB228OgJIHzOIHY7W6SFFR5Itej45eQTTLNgwTkG65MLSog238 iGvi9nJqlsTsoSnwCq+79X7TVN5/J+XafKNPQaE8z0qNZb11Qp1464VRtNPmwDO1WaEX jpO+9JKIe64QjkkrWjjzcgnhFGmnZx2omO0z9JGSpGObBPhzUiprbjV5bA38u6tlgvR7 Y2xPJUGcYCrGo5D68cofQnW50jkD50mon05siAbN3AwBpKPFQWhKTX8fAfoPRzQV4ozO DUoQ== X-Gm-Message-State: APjAAAVNIpl2BT6gGEzKxSvLDNthqsrOXQvsFkJILhgJQuIQqMeknq88 j7QoGw45RzaFbxB5ivAQaZxwlBBdzhdvKA== X-Received: by 2002:a17:90a:a403:: with SMTP id y3mr11363720pjp.118.1568482371871; Sat, 14 Sep 2019 10:32:51 -0700 (PDT) Received: from ?IPv6:2605:e000:100e:83a1:ac0e:af6d:e28f:9b10? ([2605:e000:100e:83a1:ac0e:af6d:e28f:9b10]) by smtp.gmail.com with ESMTPSA id r12sm35993995pgb.73.2019.09.14.10.32.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Sep 2019 10:32:50 -0700 (PDT) Subject: Re: [PATCH] bfq: Fix bfq linkage error To: "Pavel Begunkov (Silence)" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <9afc7a2cd013344290096d9dfe9355bcb57b3bbd.1568482098.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: <333de59c-d4ca-3bc2-fffa-35d60bd14126@kernel.dk> Date: Sat, 14 Sep 2019 11:32:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <9afc7a2cd013344290096d9dfe9355bcb57b3bbd.1568482098.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote: > From: Pavel Begunkov > > Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses > blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it > causes linkage error if bfq compiled as a module. Thanks, I'll apply and add the Fixes tag. -- Jens Axboe