Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp2646318ybe; Sat, 14 Sep 2019 20:37:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqyazfWLp07SfknyQ3zzqcMDFafLQPk87oZtHpCU/5bAVMRAS+EVG4RBkwqZbJ+ppwQPou6n X-Received: by 2002:a17:906:d926:: with SMTP id rn6mr9829794ejb.175.1568518641616; Sat, 14 Sep 2019 20:37:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568518641; cv=none; d=google.com; s=arc-20160816; b=K5PbJmxKw8YA0Nmr5lnNGzCxpT7S4BmDmobJJS3+kS//H3WpbACeO0PlheqNRbPFqh poi3HdPLr8NIVIDVEYElYDxIU7gJz9G4cNER/ssr7eLnGM0r9IMPoehUCaD1Oqm6TCdM kuWAz/ElLeaD7TmiXEZCKng4h6oc0T+u12IGP3eYpoflAwW9EHpV/oO/9mhULGHz6pki FOy8cnJRM7NMIKGm76Uoxy/O2eOFdHQeoNKVcf/GYlz6GOWnEXTBeWtR0Cx+VtWS5aAK 7mF3M9/kmdT1sdtg+/7FiEHM1kQGtzZUJ9CeKK8WlyCKw94dXnV4JB00wx2umRbuyLbJ /+jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=o1IV+RgRB1rX1e4jTpq+HTfzhsVAShE1DHXmX11eZT0=; b=wNyObYohalzCgcZX4T6x3DLL4Ltoicuzm8xYC2EU9Is0CdYjOo+uJQG4D8CLN0KudN MG2wCJEdxUdC6dD15PZeZSaQI+l1yqxIQNKdPiGjK8tlbWCaTR47bM5X18Kz8GBE2bV/ WhJLy6KpZyDBZWKc4ce5uMUaReLcMbRmRfRjcuJRfKCUQkB+FfBJ1s+YDsCTtHMa8Ylp 2T5RfxAYYUZDRHc6tXIAbuIBoLn+w4F5FserNiKZrTxr8LEXhsw6i43SB1dQVXiBk2SP 3Em4o5E1jn32p+rPshSJhsLA9asDl0hTHuAeJOXlXk1i9NY+dTKwKtGv+VSRCYbPlw1w anVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c4si18288649edv.49.2019.09.14.20.36.57; Sat, 14 Sep 2019 20:37:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727017AbfIOD0Y (ORCPT + 99 others); Sat, 14 Sep 2019 23:26:24 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2219 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725943AbfIOD0X (ORCPT ); Sat, 14 Sep 2019 23:26:23 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 0B86862CC76848BE9217; Sun, 15 Sep 2019 11:26:21 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Sun, 15 Sep 2019 11:26:13 +0800 From: Mao Wenan To: , , CC: , , , Mao Wenan Subject: [PATCH] usbip: vhci_hcd indicate failed message Date: Sun, 15 Sep 2019 11:43:32 +0800 Message-ID: <20190915034332.21168-1-maowenan@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the return value of vhci_init_attr_group and sysfs_create_group is non-zero, which mean they failed to init attr_group and create sysfs group, so it would better add 'failed' message to indicate that. Fixes: 0775a9cbc694 ("usbip: vhci extension: modifications to vhci driver") Signed-off-by: Mao Wenan --- drivers/usb/usbip/vhci_hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 000ab7225717..dd54c95d2498 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c @@ -1185,12 +1185,12 @@ static int vhci_start(struct usb_hcd *hcd) if (id == 0 && usb_hcd_is_primary_hcd(hcd)) { err = vhci_init_attr_group(); if (err) { - pr_err("init attr group\n"); + pr_err("init attr group failed\n"); return err; } err = sysfs_create_group(&hcd_dev(hcd)->kobj, &vhci_attr_group); if (err) { - pr_err("create sysfs files\n"); + pr_err("create sysfs failed\n"); vhci_finish_attr_group(); return err; } -- 2.20.1