Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932357AbVL0VzU (ORCPT ); Tue, 27 Dec 2005 16:55:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932358AbVL0VzU (ORCPT ); Tue, 27 Dec 2005 16:55:20 -0500 Received: from zproxy.gmail.com ([64.233.162.195]:47239 "EHLO zproxy.gmail.com") by vger.kernel.org with ESMTP id S932357AbVL0VzT convert rfc822-to-8bit (ORCPT ); Tue, 27 Dec 2005 16:55:19 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=t8HF3us2MH9zLaJ6qMTVZtpM7g9E3VJTvBozg9zGsDcZXfQBrji9tlg9zYv8yeoCQENvz7zEfwV9bxCXQ4m9JrRHxNv4AybXaYryfRtTN5oJqNGfqk/VojC50piu9FeTTvNKNNF+FajX5f/WVBQ4Hx2p2NPZKmRJyptv6YyEMAU= Message-ID: Date: Tue, 27 Dec 2005 16:55:18 -0500 From: Dmitry Torokhov Reply-To: dtor_core@ameritech.net To: Pavel Machek Subject: Re: [linux-pm] [patch] pm: fix runtime powermanagement's /sys interface Cc: Andrew Morton , kernel list , Linux-pm mailing list In-Reply-To: <20051227213439.GA1884@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <20051227213439.GA1884@elf.ucw.cz> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 21 On 12/27/05, Pavel Machek wrote: > > static ssize_t state_show(struct device * dev, struct device_attribute *attr, char * buf) > { > - return sprintf(buf, "%u\n", dev->power.power_state.event); > + if (dev->power.power_state.event) > + return sprintf(buf, "suspend\n"); > + else > + return sprintf(buf, "on\n"); > } Are you sure that having only 2 options (suspend/on) is enough at the core level? I could envision having more levels, like "poweroff", etc? -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/