Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 15 Sep 2019 16:19:43 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Pavel Machek <pavel@denx.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Ladi Prosek <lprosek@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Liran Alon <liran.alon@oracle.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 4.19 043/190] KVM: hyperv: define VP assist page helpers
Message-ID: <20190915201943.GQ1546@sasha-vm>
References: <20190913130559.669563815@linuxfoundation.org>
 <20190913130603.202370862@linuxfoundation.org>
 <20190915190130.GA18580@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20190915190130.GA18580@amd>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Sep 15, 2019 at 09:01:30PM +0200, Pavel Machek wrote:
>On Fri 2019-09-13 14:04:58, Greg Kroah-Hartman wrote:
>> [ Upstream commit 72bbf9358c3676bd89dc4bd8fb0b1f2a11c288fc ]
>>
>> The state related to the VP assist page is still managed by the LAPIC
>> code in the pv_eoi field.
>
>I don't get it.
>
>>
>> +bool kvm_hv_assist_page_enabled(struct kvm_vcpu *vcpu)
>> +{
>> +	if (!(vcpu->arch.hyperv.hv_vapic & HV_X64_MSR_VP_ASSIST_PAGE_ENABLE))
>> +		return false;
>> +	return vcpu->arch.pv_eoi.msr_val & KVM_MSR_ENABLED;
>> +}
>> +EXPORT_SYMBOL_GPL(kvm_hv_assist_page_enabled);
>> +
>> +bool kvm_hv_get_assist_page(struct kvm_vcpu *vcpu,
>> +			    struct hv_vp_assist_page *assist_page)
>> +{
>> +	if (!kvm_hv_assist_page_enabled(vcpu))
>> +		return false;
>> +	return !kvm_read_guest_cached(vcpu->kvm, &vcpu->arch.pv_eoi.data,
>> +				      assist_page, sizeof(*assist_page));
>> +}
>> +EXPORT_SYMBOL_GPL(kvm_hv_get_assist_page);
>> +
>
>This adds two functions, but not their users. What bug is it fixing? I
>don't see any users in the next patch, either.

Look closer at the following patch.

--
Thanks,
Sasha