Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3588947ybe; Sun, 15 Sep 2019 19:32:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwCZnH9SPkgCbynEAw+u3MwcRNFviEF0TSlp7A+2DLvXS6DH7J4X7r4fFa+Gc95M6r8j4PS X-Received: by 2002:a17:906:ece8:: with SMTP id qt8mr49263627ejb.5.1568601169501; Sun, 15 Sep 2019 19:32:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568601169; cv=none; d=google.com; s=arc-20160816; b=Mz/iqtIxP19ZfG9Kxp2Ap49HM51/9CYw5R885TSSeg/OncPEUYSqbUJcAeCmq89Nuo mnLTvk8pGpGZ93VWpM1XG3kUcpJiul3XbELLzT22zn4Nrv/xx2hoHv87ChLUZXbh9xkb v3vEH9Ton5h6fqFt4G+fpXgZC+u/ERZGdxns0gm5+yRVY2voeXZQh1BGpFn94a/mYFc8 LzW87Kcp6n/XHy9mlxB6VXOqbnvh3GEtoq2J8FwbynNG+Y0mfCZM1L6kMCDhKCvz8Ooz ftmo53CbJVrulF4c9BrfDAZ3VzkjR4Vrgl+7G0rRI9tGk76skNsQWuC++gayROYu/twQ W68A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=gQdTRLfDQUCYZ+ePsNsrBtHX9iXkkifpvhZzWmMPBiI=; b=kJthAESKg2ZNztt63+ZYqjVqmZoysTcBJkjsWNPOmBHLK7kJYFA7Du0pnhMoDoms28 IvZrZSSX2NwK3sAN/K4xcz8z9RtCT6ZcLJYZYrCqhxGWM6eKvUzQUlHNiwl/GocDkRQz wcQE2KJmPqWeZiXylAIZ22sA/bzV2zD4PvtHmP4eGdxmb5QKGbEFWjPL2TdlF6Ow/eFr KOR9d0o+XUJKVwG2ukVOHBfpnBkXd60NpECrNpS8pFyYWSK0OFIbqPSOgBINbV45if1n OS6ST2iHDPHO9pNPi8CRnKPDpFBBFOW4s1YT/okqfEr0WI7vIN42HvvGYTN6dBSssGUQ dJrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=G5aA3r6T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x51si20941195eda.272.2019.09.15.19.32.25; Sun, 15 Sep 2019 19:32:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=G5aA3r6T; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbfIOWA0 (ORCPT + 99 others); Sun, 15 Sep 2019 18:00:26 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54607 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbfIOWA0 (ORCPT ); Sun, 15 Sep 2019 18:00:26 -0400 Received: by mail-wm1-f67.google.com with SMTP id p7so7932775wmp.4 for ; Sun, 15 Sep 2019 15:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gQdTRLfDQUCYZ+ePsNsrBtHX9iXkkifpvhZzWmMPBiI=; b=G5aA3r6TGufs7D9PUrvFhJV77rAX2+dF3xkNzIvlCB8lcuhcCRxFrl8IiCsz5+pCqR iGIs76v3Opqsb+jWi23TZVohDPeIxd7DZvJtF0mo/VpQ+PpFdYdsrM69qOaKK15naVBP 7tKHqHsjSZJEegoIElIXGx71lJpP7YlugQpshwV7RJpUzqdgNQWIgSXotexOWJpwtB/3 ZFBZ6IpjBj+j/E7IztCJSFI7U1o7aaGMT1nUp7ERh4b7AOWSHqpesjH1GzTvIUYFp91O jxeVhPDa75ck8OBZ76QIbjnN5EYf5tdddikeEFumaQifoVFW9NwwRnjxV8/8o/KihONO sHEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gQdTRLfDQUCYZ+ePsNsrBtHX9iXkkifpvhZzWmMPBiI=; b=mziA6XPCungoYdIDilq9BcRZbOPcIdRAJrPVdxHGM1IQeEO0SgmIkXS2nodkOBQ34s pwqcG/dcn4t+RT6AH9JvfqNoMRMjvecs1Qch7U0SW6I1qdes8Ztbb0QsNeDQUzISRlcL qVjJweYbPW0c7EPH8AL9zq61lWpcqQ4yqYn+sURlrwKzL0PNM1wRx3LE605gf1R9o0nU 8b1L+XLee1tya7gHV8mcNLMZzgdQB1I/ynwGg6ufSjv7Z8bapeb+n9SuvNFGJWEBkCRD xgOoCFCVp9rmO5Hbbna+ie5cCEA3g+qmTERZKpdFRt2M7YiRckK6n0eA/K/3V2sdy8X+ NnMw== X-Gm-Message-State: APjAAAUvXZTIlivYCIG6zNbuyPo0nuNuECWwp+xDVLXgERX7dFZ2nrPx Cyqi8QfAfADYaawPdMrJdZ5FcyOOG+tV8LECLh4= X-Received: by 2002:a1c:be02:: with SMTP id o2mr10910147wmf.109.1568584822928; Sun, 15 Sep 2019 15:00:22 -0700 (PDT) MIME-Version: 1.0 References: <1563602720-113903-1-git-send-email-chengzhihao1@huawei.com> <0B80F9D4116B2F4484E7279D5A66984F7A7472@dggemi524-mbx.china.huawei.com> <0B80F9D4116B2F4484E7279D5A66984F7C0325@dggemi524-mbx.china.huawei.com> In-Reply-To: <0B80F9D4116B2F4484E7279D5A66984F7C0325@dggemi524-mbx.china.huawei.com> From: Richard Weinberger Date: Mon, 16 Sep 2019 00:00:10 +0200 Message-ID: Subject: Re: [PATCH] ubifs: ubifs_tnc_start_commit: Fix OOB in layout_in_gaps To: chengzhihao Cc: "zhangyi (F)" , Richard Weinberger , Sascha Hauer , Artem Bityutskiy , LKML , "linux-mtd@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 10:01 AM chengzhihao wrote: > > > ubifs_assert(c, p < c->gap_lebs + c->lst.idx_lebs); > > I've done 50 problem reproduces on different flash devices and made sure that the assertion was not triggered. See record.txt for details. Thanks for letting me know. :) I need to give this another thought, then we can apply it for -rc2.