Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190911141552.rtpdazx3ekfgsh3v@raspberrypi>
In-Reply-To: <20190911141552.rtpdazx3ekfgsh3v@raspberrypi>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Mon, 16 Sep 2019 07:21:45 +0900
Message-ID: <CADLLry5B07+Bqh5iys4tHi9OKsGGonmus0xZ4SzfK_ktceS9AQ@mail.gmail.com>
Subject: Re: [RESEND PATCH] ARM: module: Drop 'rel->r_offset < 0' statement
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>,
        allison@lohutok.net, info@metux.net,
        matthias.schiffer@ew.tq-group.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello, Maintainer(Russell King)...
Would you please update the feedback for this patch?

2019=EB=85=84 9=EC=9B=94 11=EC=9D=BC (=EC=88=98) =EC=98=A4=ED=9B=84 11:16, =
Austin Kim <austindh.kim@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> Since rel->r_offset is declared as Elf32_Addr,
> this value is always non-negative.
> typedef struct elf32_rel {
>   Elf32_Addr    r_offset;
>   Elf32_Word  r_info;
> } Elf32_Rel;
>
> typedef __u32   Elf32_Addr;
> typedef unsigned int __u32;
>
> Drop 'rel->r_offset < 0' statement which is always false.
> Also change %u to %d in pr_err() for rel->r_offset.
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  arch/arm/kernel/module.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c
> index deef17f34..f805bcbda 100644
> --- a/arch/arm/kernel/module.c
> +++ b/arch/arm/kernel/module.c
> @@ -92,8 +92,8 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab,=
 unsigned int symindex,
>                 sym =3D ((Elf32_Sym *)symsec->sh_addr) + offset;
>                 symname =3D strtab + sym->st_name;
>
> -               if (rel->r_offset < 0 || rel->r_offset > dstsec->sh_size =
- sizeof(u32)) {
> -                       pr_err("%s: section %u reloc %u sym '%s': out of =
bounds relocation, offset %d size %u\n",
> +               if (rel->r_offset > dstsec->sh_size - sizeof(u32)) {
> +                       pr_err("%s: section %u reloc %u sym '%s': out of =
bounds relocation, offset %u size %u\n",
>                                module->name, relindex, i, symname,
>                                rel->r_offset, dstsec->sh_size);
>                         return -ENOEXEC;
> --
> 2.11.0
>