Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3716195ybe; Sun, 15 Sep 2019 23:11:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwjJGqmbd2wgR96Vtw0GykLwn+RLdVkjOPcLU12qpkRn9ohfXcG8rmEyUp/mlUDKOaghSkY X-Received: by 2002:a17:907:2065:: with SMTP id qp5mr49265073ejb.151.1568614281619; Sun, 15 Sep 2019 23:11:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568614281; cv=none; d=google.com; s=arc-20160816; b=nmrfkDsF/7RtY549C8wgh/foK8cym1s6zbWYBEtC1BC592EjxpwyELcqXEXD0vPnUS ttcdsUheXVQjtNxlYPp7K7eTTfSlo+32GLCC9ZQ1v8Uxjkkx4CNceAfAPi6pZmZ+k7rU xg8LCp3aXZpd/2cNvLcw1TvdSQdNJ9hNp/gMJKijYwdFFRmO05NG5CuDYrXxQn/CRDuo UzvB2zEASuCNNHdOkz+gbOrwPwB1hQ5spbeeugBdAI3Zn4XjjBoOIvJOqbIgkiyj++W7 5opJ3CexsdTdDjWsjk+Axt6xdHkyVdqmulxCKSzNxkZND+VUlKwttkbUW4kY/LpFYWzm z0GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=N+ZNmX0/7uNFNhMLVA1exUGOaKkJhK2NGfxQt0eDsV8=; b=ftUMRVu/99zj7BHxP+H+TkYHs8QQDPWd7Pl69+YakZnpcB5V/Ib4XWiMVEwPpw7P3q mjDM5OPES4cSwDfSvOOTMC6t6FGP7RU+lYJIovzEUndNNGYmzO0bev+7MHTKZ5kB+AXM bH5MwZJga+JC0UpyzPAw2GF1pNYxyfMrRbDIZu/XmlvMANf6Nh2KMSy1X1rJzGWPa7jS 2O/h5fy/qbd3dDRHQffB42/J95hG97A7HWhGRn7DZibHjmZ5KBslHbioSSViMsITmAYV GXPv35DkLi2H83tyZlSIYTRfHEBa/zwMmE42YpYxPxxQi+sYNVcDz1PORwVK7TQYi8PD mNlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c23si15309986edt.376.2019.09.15.23.10.33; Sun, 15 Sep 2019 23:11:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728965AbfIPBPu (ORCPT + 99 others); Sun, 15 Sep 2019 21:15:50 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2223 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728927AbfIPBPt (ORCPT ); Sun, 15 Sep 2019 21:15:49 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B9426788CD4FFC694493; Mon, 16 Sep 2019 09:15:47 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 09:15:45 +0800 Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files To: Jaegeuk Kim CC: , References: <20190909080108.GC21625@jaegeuk-macbookpro.roam.corp.google.com> <20190909082112.GA25724@jaegeuk-macbookpro.roam.corp.google.com> <2f5b844c-f722-6a80-a4ab-61bdd72b8be4@huawei.com> <20190909083844.GC25724@jaegeuk-macbookpro.roam.corp.google.com> <83759349-644a-b3a0-787d-e463b0565885@huawei.com> <20190909143419.GB31108@jaegeuk-macbookpro.roam.corp.google.com> <20190910115850.GA98080@jaegeuk-macbookpro.roam.corp.google.com> <2fd8940b-9ebd-d143-5ce6-c056750c596f@huawei.com> <20190910120913.GB98080@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <1ba048b4-7dac-1c98-837d-0f0456ccc560@huawei.com> Date: Mon, 16 Sep 2019 09:15:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190910120913.GB98080@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/9/10 20:09, Jaegeuk Kim wrote: >> The lock is used to protect F2FS_I(inode)->inmem_pages list... it should be kept? > Urg.. yup. I added. Reviewed-by: Chao Yu Thanks, >