Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3775132ybe; Mon, 16 Sep 2019 00:38:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqyztwlyGaDGp4rkFw2tiaqoJOuYPpaXjGeb/k6L0TCZIDHKHVVqXRsT3/e9EKtWz/J5OAsm X-Received: by 2002:aa7:cf81:: with SMTP id z1mr7407861edx.224.1568619489214; Mon, 16 Sep 2019 00:38:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1568619489; cv=pass; d=google.com; s=arc-20160816; b=dHuXfli36aHnXohj+JYYXDK/UE1DTBRJcM+W9lqNAKlNnJrf4BpmchQ0s/5N9x42BC cPU8Rat1nICv/BSFieD1ZYGRcYqndz4W9fFv6qsvr9xqiRYzJBpKdPR6x5boJi2CPg03 3hcnspiskcM4q0spfy20etlkpbOejqaiOIg3T0pP2Og6YzY5NcEL0ba688Yz1y+g6sDx Z/hCVLAj/tjgTskPgYYzAvup9ibyskB4h3HdQTNoe+cFbS2lad8nHU22XoSyeAc18iyW ZBGB/pJr12YtK61Rqqev/3TkuRZVrAN9oi2m+kW1Oe4/txPhs56+32ck4lIeAZJhOBK5 UokA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KFnu+vV3Emgd9lQvV4LU1uDFKh1nPCY+rE9r8UbqdJc=; b=c2x6dvhyOVbM9cntCRcXkG+a2Ovrol25spKiTyBu4drY9E8UReBo+jUhdRmQrRjF1d aPHFdUWTLGgXYG9/Os5CUg1WsbEI7yzD0IAdV9fKFELSyRQug4MkrX2409pWAPcgYW38 x22dTwBkHm5IncKwF85vKevilaDoKTNKin85N3iCzcL6WNl3PlFlW/DxnxbVxXiYTstB JTO6eqhjtDAQb6lI0uKCmrBK/kroIQpEo/Z+2WGJ0Eu8lfBGaqvI786s63tcVOW2neWQ 1KUP9AH0yK+AsZOgGhDMky6Q9S6/CEW7pWdxD/wulrxp2ut2+bKoCh8ec7ozarwE2HzM wmWg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@euphon.net header.s=zoho header.b="PLsaCF/Z"; arc=pass (i=1 spf=pass spfdomain=euphon.net dkim=pass dkdomain=euphon.net dmarc=pass fromdomain=euphon.net>); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id by16si3994047edb.30.2019.09.16.00.37.43; Mon, 16 Sep 2019 00:38:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@euphon.net header.s=zoho header.b="PLsaCF/Z"; arc=pass (i=1 spf=pass spfdomain=euphon.net dkim=pass dkdomain=euphon.net dmarc=pass fromdomain=euphon.net>); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729303AbfIPGW7 (ORCPT + 99 others); Mon, 16 Sep 2019 02:22:59 -0400 Received: from sender3-op-o12.zoho.com.cn ([124.251.121.243]:17926 "EHLO sender3-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728106AbfIPGW7 (ORCPT ); Mon, 16 Sep 2019 02:22:59 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1568614966; cv=none; d=zoho.com.cn; s=zohoarc; b=q7cO6nl0+/+L5iKEuWg2kOdVW3GnIEu9TUY5Zn92WkZaL2CDV2tkAfIYRqnkZlTjSTRqHSCm8h3Lm5pIez32EtESfLxiGRyjxEbvX40S4lKSYgt8SFLKl/nhYHIfiyhQaV1HMeyYwHpKp0WDVP1reuUxD6wTxWnGi+IHtQFhn+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1568614966; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To:ARC-Authentication-Results; bh=KFnu+vV3Emgd9lQvV4LU1uDFKh1nPCY+rE9r8UbqdJc=; b=kN/vs5B8WKat/YTMyvNaGzUA4gL1qR3Pc4k6qKxy/rV0EEJ86lcBXuU5fdOG9myk/Yzg9BdCPxe07Dr2GUFiKg/uvSjvleruMgPbVKJCK/ZbgUseOjssA1FCsuuk7ZuaM0XexuVQWrvGQtHSyM0k720dxHyR1bg3CiTwMKMjAtE= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=euphon.net; spf=pass smtp.mailfrom=fam@euphon.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1568614966; s=zoho; d=euphon.net; i=fam@euphon.net; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; l=456; bh=KFnu+vV3Emgd9lQvV4LU1uDFKh1nPCY+rE9r8UbqdJc=; b=PLsaCF/ZNUaXdsuUfQT3RjukIynRsfmhNBSiKf8447Pu6MBrmXP5GYoIQG+u4vta /Ecmn1jKpIICFeiODXTk9uDSYEcNha4vDSUAv0HdTV++zTLfJvNXO9Ka3pz+em7fUDY DEr46E6GelXjTAaSmgAfyiZ9tI3z109JX4JpxaPA= Received: from localhost (120.52.147.46 [120.52.147.46]) by mx.zoho.com.cn with SMTPS id 156861496368045.56814894994807; Mon, 16 Sep 2019 14:22:43 +0800 (CST) Date: Mon, 16 Sep 2019 14:22:42 +0800 From: Fam Zheng To: Jens Axboe Cc: "Pavel Begunkov (Silence)" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bfq: Fix bfq linkage error Message-ID: <20190916062242.GA25284@magic> References: <9afc7a2cd013344290096d9dfe9355bcb57b3bbd.1568482098.git.asml.silence@gmail.com> <333de59c-d4ca-3bc2-fffa-35d60bd14126@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <333de59c-d4ca-3bc2-fffa-35d60bd14126@kernel.dk> User-Agent: Mutt/1.12.1 (2019-06-15) X-ZohoCNMailClient: External Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 09/14 11:32, Jens Axboe wrote: > On 9/14/19 11:31 AM, Pavel Begunkov (Silence) wrote: > > From: Pavel Begunkov > > > > Since commit 795fe54c2a828099e ("bfq: Add per-device weight"), bfq uses > > blkg_conf_prep() and blkg_conf_finish(), which are not exported. So, it > > causes linkage error if bfq compiled as a module. > > Thanks, I'll apply and add the Fixes tag. Thanks! This is indeed my oversight. Fam