Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190912090404.89822-1-jitao.shi@mediatek.com>
In-Reply-To: <20190912090404.89822-1-jitao.shi@mediatek.com>
From:   Nicolas Boichat <drinkcat@chromium.org>
Date:   Mon, 16 Sep 2019 12:27:14 +0800
Message-ID: <CANMq1KBdZmGEO-MH33mhc4wCheJE2TBiUAXtt=YVr5aARDpiJg@mail.gmail.com>
Subject: Re: [PATCH 0/3] add panel driver for innolux,p097pfg with ssd2825 bridge
To:     Jitao Shi <jitao.shi@mediatek.com>
Cc:     Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org,
        lkml <linux-kernel@vger.kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Eddie Huang <eddie.huang@mediatek.com>,
        cawa cheng <cawa.cheng@mediatek.com>,
        =?UTF-8?B?QmliYnkgSHNpZWggKOisnea/n+mBoCk=?= 
        <bibby.hsieh@mediatek.com>, CK HU <ck.hu@mediatek.com>,
        stonea168@163.com, Sean Paul <seanpaul@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jitao,

On Thu, Sep 12, 2019 at 5:04 PM Jitao Shi <jitao.shi@mediatek.com> wrote:
>
> Add driver to support panel innolux,p097pfg with bridge ssd2858.
> SSD2858 can spilt dsi 4 lanes to 8 lanes.
>
> Jitao Shi (3):
>   drm/panel: panel-innolux: Allow 2 reset pins for panel
>   dt-bindings: display: Add documentation for innolux,p097pfg_ssd2858
>     panel
>   drm/panel: panel-innolux: Add support for P097PFZ behind SSD2858

I'm the author of at least the first patch, and at least part of the
third one, so it would have been better if you clarified the origin of
the patches.

Also, I do not believe that this is the right approach (this was
always a temporary hack that we had no intent to upstream as-is), we'd
probably want to add a proper bridge driver for SSD2858, and allow
arbitrary panels behind it.

Please consider this series
Nacked-by: Nicolas Boichat <drinkcat@chromium.org>

Thanks,

>  .../display/panel/innolux,p097pfg_ssd2858.txt |  39 +++++
>  drivers/gpu/drm/panel/panel-innolux-p079zca.c | 140 ++++++++++++++++--
>  2 files changed, 164 insertions(+), 15 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,p097pfg_ssd2858.txt
>
> --
> 2.21.0
>