Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp3917687ybe; Mon, 16 Sep 2019 03:40:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLK8pWyudvh2oKKw2PhBisgAHwxBv25GJk4BealP58JGkRfLac6ltepBd+8UDyqNyDZsIJ X-Received: by 2002:a17:906:27cf:: with SMTP id k15mr10290079ejc.150.1568630434733; Mon, 16 Sep 2019 03:40:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568630434; cv=none; d=google.com; s=arc-20160816; b=doE6MtZOS503d2RSJY/AndoVD32cp95rtrasMjniBZv61tQrQEUD7nQInwrZls+RmO X+ihlCv+ZPzhqgtOiieH05Siz32OL/F1qiy7XKILWiYkrqrq8cQfIrlUS0xVsBMB9zCt PxXNNdQGE18wO20zumxcRea7e1T+keHYCnaYDwh9jrjA+EKxY2f2PQNo0hPu79XrqGvM R7lsva0gvr8QVNIVuG47642Ka3RensyYYDyesVCMojoQWI9SGcfqWwT3AAFZDUaHWzxU lu6+iE8kFESYFwvwPZ9pnFWF+PcxWI88X/p0/TSGFCQHTHkxnxGTIRXxog7Ifs4hKqB7 YzOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=WiRvJltrkdIC4fnEHZ1FhM2lF38sZLL0RlfEreTP6xg=; b=0jJa03EdibtWCzqVUE0s6r9TeojMvwP9w/OTiE7OgmAXZhbXG5VqzWo+zFqMDRKaiw ttqtMSvqN3FOQT5bHeZx+Meh0P+Jddu0QK4qfOz5/kqmVfMNKOKHEmR0PAwIwfV2mdXh rEvToL7Qr6Gp4vML2SI4b190tFhAYF/1VH7K/12JY4XE8gyJdvXkDdSK2bp/ZtLQD6D5 P+h3MiPZwCI+2lP0e5eOsfZNMHmg5yiUTF0IjlFU+toTrfndwkDiTn1QszcAWeW1C+Pn LyRRCGADoLJXcnVDH5NTIOdLJGauv/fb8DhmigVtsVWhwSgepgd7PSgh9kaWO6IisfCE 0FSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m20si4222170eds.363.2019.09.16.03.40.11; Mon, 16 Sep 2019 03:40:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731690AbfIPJHs (ORCPT + 99 others); Mon, 16 Sep 2019 05:07:48 -0400 Received: from mga17.intel.com ([192.55.52.151]:2592 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731674AbfIPJHr (ORCPT ); Mon, 16 Sep 2019 05:07:47 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 02:07:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="176986019" Received: from opirvulx-wtg.ger.corp.intel.com (HELO localhost) ([10.252.55.135]) by orsmga007.jf.intel.com with ESMTP; 16 Sep 2019 02:07:42 -0700 Date: Mon, 16 Sep 2019 12:07:41 +0300 From: Jarkko Sakkinen To: Seunghun Han Cc: Vanya Lazeev , arnd@arndb.de, Greg Kroah-Hartman , Jason Gunthorpe , "open list:TPM DEVICE DRIVER" , Linux Kernel Mailing List , Peter Huewe Subject: Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs Message-ID: <20190916090741.GA31747@linux.intel.com> References: <20190913140006.GA29755@linux.intel.com> <20190913140218.GB29755@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 16, 2019 at 02:29:01PM +0900, Seunghun Han wrote: > > > > On Fri, Sep 13, 2019 at 03:00:06PM +0100, Jarkko Sakkinen wrote: > > > On Wed, Sep 11, 2019 at 02:17:48PM +0900, Seunghun Han wrote: > > > > Vanya, > > > > I also made a patch series to solve AMD's fTPM. My patch link is here, > > > > https://lkml.org/lkml/2019/9/9/132 . > > > > > > > > The maintainer, Jarkko, wanted me to remark on your patch, so I would > > > > like to cooperate with you. > > > > > > > > Your patch is good for me. If you are fine, I would like to take your > > > > patch and merge it with my patch series. I also would like to change > > > > some points Jason mentioned before. > > > > > > I rather handle the review processes separately because I can merge > > > Vanyas's patch first. Bundling them into patch set would only slow > > > down things. > > > > I did not ask to do anything. I just review code changes. > > I got it. I should concentrate on my ACPI NVS problem. > Thank you. Eessentially what you want to do is to detach and backup the original NVS resources and put them back to the list with insert_resource() when tpm_crb is removed. At least I think this is what should be done but you should CC your patch also to the ACPI list for feedback. /Jarkko