Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4238002ybe; Mon, 16 Sep 2019 08:51:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqw4olmQf1GAwbuh8uhyu7QTBfPxuzejillL0/KLzx2Y+SOfTGddBJU/c/hT2hY8U5lGMrEg X-Received: by 2002:a05:6402:6c6:: with SMTP id n6mr2848754edy.162.1568649082684; Mon, 16 Sep 2019 08:51:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568649082; cv=none; d=google.com; s=arc-20160816; b=VHTIOFAml4o4BorCOJZDyRwwRo06eSYZqIELlanP2PKe14+GwMV4AH0lU8WLwop1xf VLeJdqAscQ+Ppukbi3o1coigkdRnmstUx4ORakKkyLf+VZWwhSlazaKzXcPjAAIcbkBG d/iym41gxYdNdePJvA6dvLKU2SSLXYC3R+towkekZaKPZ7+982WiPZZAROWUkRogwt8P ylMT5RT8aCdtzGEzfTqtLkqN3UBIlD5cZWgm/0nbEjwW80Dg7K7S4iToIqMlduPHRFfr i268MQ87gg5kTm/cZf9Kc+Rq8rKkWGrOhAcKgr7VY+iwM8556B0nm9Jr/HGxHEH/8C3K wzDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=yrAUJSzqt77+JZRgfuqSyv5F+VqbHUmHr5hOHhySgyE=; b=st4Feag/1dhd/INvDSGnctEbqJd6vPmUfDIUCCxiXTZZeeLDLG56P42o870vlpcpmr dXfYm2gfYGylPbf/v3S7hXi8Xox8nRmuWGdpMHJzy/vuxtnIODcvNCghXhM0uB80c8CJ CB69ZKV30+ew9rsXKji7xFenyS34U/k4C3XYvGKD6dEz9ZD4HLVqXeskg/SsMjVL6xpY 6duf1tGG84lFSaq9P1FZd0Keju+POU4LHzT34p2PxuTlQGiceeJucr39IXoGedJQ46SP DqTIve1evgayB1yYv8f+vvUAz93aBkfdbCUJCmfBe07PxcK/KF0vB939uCTjsDdzMdiX dU0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8si5874677eju.333.2019.09.16.08.50.58; Mon, 16 Sep 2019 08:51:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732070AbfIPJoe convert rfc822-to-8bit (ORCPT + 99 others); Mon, 16 Sep 2019 05:44:34 -0400 Received: from ZXSHCAS2.zhaoxin.com ([203.148.12.82]:11818 "EHLO ZXSHCAS2.zhaoxin.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729400AbfIPJod (ORCPT ); Mon, 16 Sep 2019 05:44:33 -0400 Received: from zxbjmbx3.zhaoxin.com (10.29.252.165) by ZXSHCAS2.zhaoxin.com (10.28.252.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1261.35; Mon, 16 Sep 2019 17:44:28 +0800 Received: from zxbjmbx1.zhaoxin.com (10.29.252.163) by zxbjmbx3.zhaoxin.com (10.29.252.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1261.35; Mon, 16 Sep 2019 17:44:27 +0800 Received: from zxbjmbx1.zhaoxin.com ([fe80::b41a:737:a784:b70d]) by zxbjmbx1.zhaoxin.com ([fe80::b41a:737:a784:b70d%16]) with mapi id 15.01.1261.035; Mon, 16 Sep 2019 17:44:27 +0800 From: Tony W Wang-oc To: Thomas Gleixner CC: "tony.luck@intel.com" , "Borislav Petkov (bp@alien8.de)" , "mingo@redhat.com" , "hpa@zytor.com" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "yazen.ghannam@amd.com" , "vishal.l.verma@intel.com" , "qiuxu.zhuo@intel.com" , David Wang , "Cooper Yan(BJ-RD)" , "Qiyuan Wang(BJ-RD)" , "Herry Yang(BJ-RD)" Subject: Re: [PATCH v3 2/4] x86/mce: Make 3 functions non-static Thread-Topic: [PATCH v3 2/4] x86/mce: Make 3 functions non-static Thread-Index: AdVsbNK9Ze8Vv2u/TlS+IY5QKGD9vg== Date: Mon, 16 Sep 2019 09:44:27 +0000 Message-ID: <966609ae83b947b998a85cd2fcc1f304@zhaoxin.com> Accept-Language: en-US, zh-CN Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.32.64.75] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 16, 2019, Thomas Gleixner wrote: >On Wed, 11 Sep 2019, Tony W Wang-oc wrote: > >> These functions are declared static and cannot be used in others >> .c source file. this commit removes the static attribute and adds >> the declaration to the header for these functions. > >I'm not Cc'ed on any patches which use those functions. Please Cc the >relevant maintainers on all patches of such a patch series so contect can >be seen. > Patches 3/4, 4/4 in this patchsets are using these functions. Specifically, "[PATCH v3 3/4] x86/mce: Add Zhaoxin CMCI support " in this patchsets is using intel_init_cmci(), "[PATCH v3 4/4] x86/mce: Add Zhaoxin LMCE support" is using intel_init_lmce() and intel_clear_lmce(). I had sent all patches in this patchsets to your mailbox. Could you help to check again? Thank you. >Also adding some hint to the change log which new code will use that would >be appreciated. Got it, will add in next version. Sincerely TonyWWang-oc