Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190911084759.6946-1-benjamin.gaignard@st.com> <8235afe0-1796-1647-8a39-84ab354e290a@amd.com>
In-Reply-To: <8235afe0-1796-1647-8a39-84ab354e290a@amd.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Mon, 16 Sep 2019 15:15:18 +0200
Message-ID: <CA+M3ks7kUjQB0ZkHmugWZt6fUA7ytQcjXu8G9pDFejQpdyNxcw@mail.gmail.com>
Subject: Re: [PATCH] drm: fix warnings in DSC
To:     Harry Wentland <hwentlan@amd.com>
Cc:     Benjamin Gaignard <benjamin.gaignard@st.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "manasi.d.navare@intel.com" <manasi.d.navare@intel.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le mer. 11 sept. 2019 =C3=A0 15:41, Harry Wentland <hwentlan@amd.com> a =C3=
=A9crit :
>
> On 2019-09-11 4:47 a.m., Benjamin Gaignard wrote:
> > Remove always false comparisons due to limited range of nfl_bpg_offset
> > and scale_increment_interval fields.
> > Warnings detected when compiling with W=3D1.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Applied on drm-misc-next
Thanks,
Benjamin

>
> Harry
>
> > ---
> >  drivers/gpu/drm/drm_dsc.c | 11 -----------
> >  1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c
> > index 77f4e5ae4197..27e5c6036658 100644
> > --- a/drivers/gpu/drm/drm_dsc.c
> > +++ b/drivers/gpu/drm/drm_dsc.c
> > @@ -336,12 +336,6 @@ int drm_dsc_compute_rc_parameters(struct drm_dsc_c=
onfig *vdsc_cfg)
> >       else
> >               vdsc_cfg->nfl_bpg_offset =3D 0;
> >
> > -     /* 2^16 - 1 */
> > -     if (vdsc_cfg->nfl_bpg_offset > 65535) {
> > -             DRM_DEBUG_KMS("NflBpgOffset is too large for this slice h=
eight\n");
> > -             return -ERANGE;
> > -     }
> > -
> >       /* Number of groups used to code the entire slice */
> >       groups_total =3D groups_per_line * vdsc_cfg->slice_height;
> >
> > @@ -371,11 +365,6 @@ int drm_dsc_compute_rc_parameters(struct drm_dsc_c=
onfig *vdsc_cfg)
> >               vdsc_cfg->scale_increment_interval =3D 0;
> >       }
> >
> > -     if (vdsc_cfg->scale_increment_interval > 65535) {
> > -             DRM_DEBUG_KMS("ScaleIncrementInterval is large for slice =
height\n");
> > -             return -ERANGE;
> > -     }
> > -
> >       /*
> >        * DSC spec mentions that bits_per_pixel specifies the target
> >        * bits/pixel (bpp) rate that is used by the encoder,
> >