Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp4562734ybe; Mon, 16 Sep 2019 14:31:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9jADUWIIXqL6LNmbHXDWHqvM8TGGDh6NfVQH7IPxPF4rgBfnzwps3FPH/GqEUVdQqyM70 X-Received: by 2002:a17:906:944b:: with SMTP id z11mr1928503ejx.46.1568669474933; Mon, 16 Sep 2019 14:31:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568669474; cv=none; d=google.com; s=arc-20160816; b=tzfLUZPWmO8vPfEbGL+3WyxrQ3FkNWI8KxXwrhuMCbT59PdN5My0SckYJYd998jcOf hE5oPIdWS8h2QjPuzjLtIQyr2bgSf6JHQ5ZyOy95iXsVxu9Z8l1+eRx7yW3KiLjdwobM KM2OC1HCBlUZTruRyNtZDKFc1Mot6QksPllgfZWoCH60/vw5AhbBdOvmgBIbuQbiSVVp JbFCCkGouK5tPSzfMLJRTCCiCIJfELoKX8U9AmRdWokwdye8oQuGuaHcr7DwqXOV3xDW prGUcuA1xL+Z6vtpZ4rqaK1zIPLnK3kXHQq35Q6qUrgtFJ6wzBap8vRGJlhZubKPsAaQ WkCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:organization:references:in-reply-to:date:cc:to:from :message-id; bh=DhywiDpM0giZL6Hul+DindZccpTnDMUlQ1ZVj0ReF0E=; b=Si4yAXXfc7tcznU/IyplwE8Rzc8bXX+NTc05kRCRgWMLPngdiVi38tPttgd36Zp182 nKVLrhoHmg86lueconARIs7bQDell8zYcUyhHC17rg1m83qSfRH31Qcfkt7rDMlLXZUJ 5udhEVjkga9DAB8nO2DGrXWH6K1fXeRkclDzELkXVFgsko5YFhQIP8s3d7PLQMFjUs0x 7HvnOpLLF/V4yg7zvzAQ798IdAyPvsFa2CHdryNcmarJb9kTTkA/EIiUmkcIJ46DZQmw cOQP0bjFCSDwsBd+8X6MJLaM4MoYR6Rh1f/CDb7JHdFkZj+SwHQVdiZGW2xNX37V0egD 7u3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x51si174708edd.193.2019.09.16.14.30.51; Mon, 16 Sep 2019 14:31:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730237AbfIPPGu (ORCPT + 99 others); Mon, 16 Sep 2019 11:06:50 -0400 Received: from baldur.buserror.net ([165.227.176.147]:34794 "EHLO baldur.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728065AbfIPPGu (ORCPT ); Mon, 16 Sep 2019 11:06:50 -0400 Received: from [2601:449:8480:af0:12bf:48ff:fe84:c9a0] by baldur.buserror.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9sYG-0008L7-6q; Mon, 16 Sep 2019 10:04:28 -0500 Message-ID: <71490f3b94b851106eb48c8909239f401d0018d1.camel@buserror.net> From: Scott Wood To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , galak@kernel.crashing.org Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Mon, 16 Sep 2019 10:04:27 -0500 In-Reply-To: <7f8f9747ef1ab2e1261cf83b03c1da321d47f7b7.1568616151.git.christophe.leroy@c-s.fr> References: <966e6d6a226f9786098d296239a6c65064e73a41.1568616151.git.christophe.leroy@c-s.fr> <7f8f9747ef1ab2e1261cf83b03c1da321d47f7b7.1568616151.git.christophe.leroy@c-s.fr> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2601:449:8480:af0:12bf:48ff:fe84:c9a0 X-SA-Exim-Rcpt-To: christophe.leroy@c-s.fr, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, galak@kernel.crashing.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on baldur.localdomain X-Spam-Level: X-Spam-Status: No, score=-17.5 required=5.0 tests=ALL_TRUSTED,BAYES_00, GREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -1.5 GREYLIST_ISWHITE The incoming server has been whitelisted for * this recipient and sender Subject: Re: [PATCH v2 2/2] powerpc/83xx: map IMMR with a BAT. X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-09-16 at 06:42 +0000, Christophe Leroy wrote: > @@ -145,6 +147,15 @@ void __init mpc83xx_setup_arch(void) > if (ppc_md.progress) > ppc_md.progress("mpc83xx_setup_arch()", 0); > > + if (!__map_without_bats) { > + phys_addr_t immrbase = get_immrbase(); > + int immrsize = IS_ALIGNED(immrbase, SZ_2M) ? SZ_2M : SZ_1M; > + unsigned long va = __fix_to_virt(FIX_IMMR_BASE); Why __fix_to_virt() and not fix_to_virt()? -Scott